Skip to content

[fix][cp] misc: Fix the typos found in the aggregate#443

Open
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
WangGuangxin:cp_11998
Open

[fix][cp] misc: Fix the typos found in the aggregate#443
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
WangGuangxin:cp_11998

Conversation

@WangGuangxin
Copy link
Copy Markdown
Collaborator

@WangGuangxin WangGuangxin commented Mar 30, 2026

What problem does this PR solve?

Issue Number: close #191

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

Fix the typos found in the aggregate

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

Summary: Pull Request resolved: facebookincubator/velox#11998

Reviewed By: amitkdutta

Differential Revision: D67764870

Pulled By: kevinwilfong

fbshipit-source-id: 7c32c72b077038494944ad42f61f0e471c159d7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants