[fix][cp] Remove DictEncoder dtor checking in Parquet writer#435
Open
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
Open
[fix][cp] Remove DictEncoder dtor checking in Parquet writer#435WangGuangxin wants to merge 1 commit intobytedance:mainfrom
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
Conversation
Collaborator
Author
WangGuangxin
force-pushed
the
cp_10445
branch
3 times, most recently
from
96e8da7 to
be130ac
Compare
Summary: Below exception is noticed when running spark_aggregation_fuzzer_test with facebookincubator/velox#9559, which writes Velox vectors into Parquet files for Spark to read. ``` velox/dwio/parquet/writer/arrow/Encoding.cpp:513: Check failed: buffered_indices_.empty() ./velox/functions/sparksql/fuzzer/spark_aggregation_fuzzer_test ``` This PR follows apache/arrow@02ad5ae to remove this check. Pull Request resolved: facebookincubator/velox#10445 Reviewed By: kagamiori Differential Revision: D59814851 Pulled By: mbasmanova fbshipit-source-id: a72e6f7608d8bb1763e11e57ef1e5b8daa40f9cf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #191
Type of Change
Description
Summary:
Below exception is noticed when running spark_aggregation_fuzzer_test with facebookincubator/velox#9559, which writes Velox vectors into Parquet files for Spark to read.
This PR follows apache/arrow@02ad5ae to remove this check.
Corresponding PR: facebookincubator/velox#10445
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes