chore: Remove internal adk golden test in favor of actual adk tests#136
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
Abhijeet Prasad (AbhiPrasad)
requested a review
from ViaDézo1er / cedric (viadezo1er)
Abhijeet Prasad (AbhiPrasad)
changed the title
ViaDézo1er / cedric (viadezo1er)
requested changes
Mar 24, 2026
|
|
||
|
|
||
| PROJECT_NAME = "test_adk" | ||
| FIXTURES_DIR = Path(__file__).parent.parent.parent.parent.parent.parent / "internal" / "golden" / "fixtures" |
Contributor
There was a problem hiding this comment.
There are only 2 files (test-document.pdf and test-image.png) in internal/golden/fixtures, move them instead?
Member
Author
There was a problem hiding this comment.
They are unfortunately being used by the other internal/golden tests. For now this is okay until we remove all of the golden tests - we can migrate over the fixtures to a better location then.
ViaDézo1er / cedric (viadezo1er)
approved these changes
Mar 25, 2026
Contributor
ViaDézo1er / cedric (viadezo1er)
left a comment
ViaDézo1er / cedric (viadezo1er)
left a comment
There was a problem hiding this comment.
good to merge then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes our manual internal golden test for adk-py in favour of more robust tests for the actual adk instrumentation.
This helps clean up code that is getting stale, as these golden tests don't run in CI.