chore: Add benchmarking setup to SDK#135
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
Abhijeet Prasad (AbhiPrasad)
requested a review
from ViaDézo1er / cedric (viadezo1er)
ViaDézo1er / cedric (viadezo1er)
approved these changes
Mar 24, 2026
| pre-commit | ||
| pydoc-markdown | ||
| pylint | ||
| pyperf |
Contributor
There was a problem hiding this comment.
Pin a version?
Member
Author
There was a problem hiding this comment.
Yeah we should do that for all the requirements-dev packages. Will do it in a follow up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #134
I want to work on merging in #101
This adds a benchmarking harness to the SDK so we can make changes like this easy.
The harness itself relies completely on https://pyperf.readthedocs.io/en/latest/index.html, but I've adjusted some stuff for os compat and making it work for our repo.
Docs wise, I've updated
CONTRIBUTING.md,AGENTS.md, and added a new agent skill for benchmarking.For now these benchmarks are meant to run completely locally, but we can explore running them in CI or in a devbox.