Cedric/remove dead code#117
Draft
ViaDézo1er / cedric (viadezo1er) wants to merge 8 commits intomainfrom
Draft
Conversation
ViaDézo1er / cedric (viadezo1er)
requested a review
from Abhijeet Prasad (AbhiPrasad)
Contributor
Author
|
I need to review the need human review commits, otherwise this PR is probably done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #98
As advised by Abhi, used vulture to find unused code.
Only targeted code with 100 confidence, should I also target confidence of 60?
Pytest fixtures aren't handled well so some are whitelisted in the pyproject.toml
vulturestill findsdataset_record_idin logger.py, but the docstring indicates we might want to keep it for now (maybe for backward compatibility?).Need another opinion on this.
Some variables had their name changed by prefixing them with a _, this is cosmetic and indicates to vulture this is voluntarily unused.