Use new ringbuffers in SoftUgnDemo#1213
Draft
lmbollen wants to merge 14 commits intolucas/ringbuffer-components2from
Draft
Use new ringbuffers in SoftUgnDemo#1213lmbollen wants to merge 14 commits intolucas/ringbuffer-components2from
SoftUgnDemo#1213lmbollen wants to merge 14 commits intolucas/ringbuffer-components2from
Conversation
lmbollen
force-pushed
the
lucas/use-ringbuffers
branch
from
149cc19 to
291bec5
Compare
lmbollen
force-pushed
the
lucas/use-ringbuffers
branch
from
291bec5 to
3e47f7b
Compare
lmbollen
force-pushed
the
lucas/addressable-bytes-wb
branch
from
580376d to
14583fb
Compare
lmbollen
force-pushed
the
lucas/use-ringbuffers
branch
4 times, most recently
from
1c7a78c to
0f17d8c
Compare
lmbollen
changed the base branch from
lucas/addressable-bytes-wb
to
lucas/ringbuffer-components2
lmbollen
force-pushed
the
lucas/ringbuffer-components2
branch
2 times, most recently
from
3636a35 to
31f3124
Compare
lmbollen
force-pushed
the
lucas/use-ringbuffers
branch
from
0f17d8c to
3bf65db
Compare
lmbollen
force-pushed
the
lucas/ringbuffer-components2
branch
from
31f3124 to
42564c2
Compare
lmbollen
force-pushed
the
lucas/use-ringbuffers
branch
from
3bf65db to
78adde2
Compare
lmbollen
force-pushed
the
lucas/ringbuffer-components2
branch
4 times, most recently
from
bd506fe to
4224b98
Compare
lmbollen
force-pushed
the
lucas/ringbuffer-components2
branch
3 times, most recently
from
29741d0 to
eb280d4
Compare
lmbollen
force-pushed
the
lucas/use-ringbuffers
branch
from
78adde2 to
3bf65db
Compare
lmbollen
force-pushed
the
lucas/ringbuffer-components2
branch
from
95d4da3 to
c9064ad
Compare
lmbollen
force-pushed
the
lucas/use-ringbuffers
branch
from
3bf65db to
f0c75ae
Compare
lmbollen
force-pushed
the
lucas/ringbuffer-components2
branch
from
9625c47 to
4213bb0
Compare
lmbollen
force-pushed
the
lucas/use-ringbuffers
branch
from
f0c75ae to
357070a
Compare
lmbollen
force-pushed
the
lucas/ringbuffer-components2
branch
from
4213bb0 to
dd62211
Compare
lmbollen
force-pushed
the
lucas/use-ringbuffers
branch
2 times, most recently
from
0bbd504 to
78f03dc
Compare
Termination checking in a sensible way got too complicated and did not make sense anymore.
lmbollen
force-pushed
the
lucas/use-ringbuffers
branch
from
3db706c to
7fd9729
Compare
lmbollen
force-pushed
the
lucas/ringbuffer-components2
branch
from
abe55b1 to
401ac58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (what did you do)
Replace the scatter and gather unit in the
SoftUgnDemowith their dedicated ringbuffer counterparts.Why (context, issues, etc.)
We aim to simplify the demos and the current scatter and gather units are used as ringbuffers.
Dear reviewer (anything you'd like the reviewer to pay close attention to?)
Are there any other places we want them? Is the rust API feature complete?
AI disclaimer (heads-up for more than inline autocomplete)
Used AI for the initial Rust HAL.
TODO
Cross-outany that do not applydocs/