Open
Conversation
f4cb42b to
efcab35
Compare
9272cbb to
4c5facf
Compare
0e17e3f to
beb7bfa
Compare
4c5facf to
ae5f929
Compare
beb7bfa to
fa3df5d
Compare
0fbfaa7 to
133ff8f
Compare
fa3df5d to
a0adbac
Compare
6c820a4 to
b043367
Compare
4c1d105 to
323b817
Compare
b043367 to
48dc51f
Compare
323b817 to
52cf480
Compare
3b469f4 to
59f362f
Compare
542437e to
e6a4972
Compare
1e426ce to
580376d
Compare
e6a4972 to
02422a8
Compare
f11cde9 to
86da3ab
Compare
42564c2 to
24261b6
Compare
86da3ab to
bee53a8
Compare
24261b6 to
d3ce3e6
Compare
bd506fe to
4224b98
Compare
4213bb0 to
dd62211
Compare
martijnbastiaan
requested changes
Apr 17, 2026
Contributor
martijnbastiaan
left a comment
There was a problem hiding this comment.
This is hard to review, because it's missing your intent. That is, there isn't sufficient documentation for me to determine that your implementation/tests matches what you had in mind. Could you take a look?
abe55b1 to
401ac58
Compare
Co-authored-by: Martijn Bastiaan <martijn@qbaylogic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (what did you do)
Add dedicated components that implement the ringbuffer memories. These components use renewed Protocols infrastructure that aims to make it easier to create components using high level composition of inherently correct
Circuits rather than creating the low level implementations by hand.Why (context, issues, etc.)
To simplify the hardware architecture and the way we describe our
Circuits.Dear reviewer (anything you'd like the reviewer to pay close attention to?)
Whether the new components and their types improves the readability / robustness of the code.
AI disclaimer (heads-up for more than inline autocomplete)
Used AI to generate the ringbuffer tests.
TODO
Cross-outany that do not applydocs/