Skip to content

Add HGLRCF435AIO config.h#952

Open
ot0tot wants to merge 2 commits intobetaflight:masterfrom
ot0tot:Add-HGLRC-F435-AIO
Open

Add HGLRCF435AIO config.h#952
ot0tot wants to merge 2 commits intobetaflight:masterfrom
ot0tot:Add-HGLRC-F435-AIO

Conversation

@ot0tot
Copy link
Copy Markdown
Contributor

@ot0tot ot0tot commented Nov 7, 2025

Checklist (✓/✕, or y/n)

  • passed Betaflight team's schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

Summary by CodeRabbit

  • New Features
    • Added support for the HGLRC F435 AIO flight controller (AT32F435G).
    • Enables onboard gyro/accelerometer, dual barometer options, flash-based Blackbox logging, and gyro clock-in.
    • Preconfigured motor outputs, UARTs, I2C/SPI peripherals, timer mappings, LED strip and beeper (inverted), and ADC-based voltage/current sensing.
    • DShot output enabled by default; default board yaw alignment and system clock preset applied.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 7, 2025

Walkthrough

Adds a new board configuration header for HGLRCF435AIO defining MCU (AT32F435G), board identifiers, enabled peripherals/sensors (ICM42688P, M25P16, BMP280/DPS310), comprehensive pin mappings (motors, UARTs, SPI, I2C, ADC, LEDs, beeper), TIMER_PIN_MAPPING, and default device presets.

Changes

Cohort / File(s) Change Summary
HGLRCF435AIO Hardware Configuration
configs/HGLRCF435AIO/config.h
New board config with ~60+ macro definitions: MCU/board/manufacturer IDs, USE_* enables (ACC/GYRO/FLASH/BARO), sensor selections (ICM42688P, M25P16, BMP280, DPS310), motor/UART/I2C/SPI/CS/EXTI/CLKIN pin mappings, ADC pins, LED/beeper/LED-strip pins, TIMER_PIN_MAPPING for motors/LEDs/gyro clock, peripheral instance selections, and default device settings (BLACKBOX_FLASH, DSHOT_BITBANG_ON, ADC meters).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify pin assignments vs schematic (motor pins, UARTs, SPI/I2C/ADC)
  • Validate TIMER_PIN_MAPPING and timer channel assignments
  • Confirm peripheral instance selections and default device macros

Possibly related PRs

Suggested reviewers

  • nerdCopter
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is incomplete; it contains only a checklist with no narrative explanation of the changes, rationale, or additional context required by the template. Add a detailed description explaining the HGLRCF435AIO configuration, its features, and why it was added. Include sections addressing hardware details, design rationale, and any relevant context beyond the checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add HGLRCF435AIO config.h' directly and clearly summarizes the main change: adding a new configuration file for the HGLRCF435AIO flight controller.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread configs/HGLRCF435AIO/config.h Outdated
@sugaarK sugaarK added the Partner Program this pr is for a target from the partner program and will automatically get tier 1 status label Dec 18, 2025
@HGLRC-T
Copy link
Copy Markdown
Contributor

HGLRC-T commented Jan 4, 2026

LGTM, So could we merge it? @ot0tot

@HGLRC-T
Copy link
Copy Markdown
Contributor

HGLRC-T commented Jan 10, 2026

Any idea?

@ot0tot
Copy link
Copy Markdown
Contributor Author

ot0tot commented Jan 12, 2026

Have you supplied hardware samples?

@HGLRC-T
Copy link
Copy Markdown
Contributor

HGLRC-T commented Jan 13, 2026

Have you supplied hardware samples?

We have completed the hardware design based on the schematics and are in the sample production stage, so we haven't provided samples yet. However, as usual, I think this target can be merged and accepted, and our schematics have been provided for your review.

@ot0tot
Copy link
Copy Markdown
Contributor Author

ot0tot commented Jan 13, 2026

If the samples haven't even been produced yet, what is the rush to merge?

@HGLRC-T
Copy link
Copy Markdown
Contributor

HGLRC-T commented Jan 14, 2026

If the samples haven't even been produced yet, what is the rush to merge?

Sorry, I was too hasty. I will do my best to follow the community guidelines.

@HGLRC-T
Copy link
Copy Markdown
Contributor

HGLRC-T commented Apr 2, 2026

Fix:
image
image

@ot0tot ,Hi, I tested your code and found these bugs.

@ot0tot
Copy link
Copy Markdown
Contributor Author

ot0tot commented Apr 2, 2026

I don't see where you responded to the problems with the schematic posted here: https://discord.com/channels/1201422947445907466/1411064407722823710/1419093938832408687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting Prototype Samples Awaiting prototype samples Partner Program this pr is for a target from the partner program and will automatically get tier 1 status Uses Betaflight Connector Standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants