Added achievement for playing multiple games with different players#81
Open
PhilipTzannis wants to merge 4 commits intobeeracademy:masterfrom
Open
Added achievement for playing multiple games with different players#81PhilipTzannis wants to merge 4 commits intobeeracademy:masterfrom
PhilipTzannis wants to merge 4 commits intobeeracademy:masterfrom
Conversation
Contributor
Author
|
Forslag til nyt achievement, for at have spillet flere spil med flere forskellige mennesker |
tyilo
reviewed
May 12, 2025
Member
There was a problem hiding this comment.
I think something is wrong with the icon
tyilo
reviewed
May 12, 2025
| top20 = sorted( | ||
| ({"x": k, "y": v} for k, v in played_with_count.items()), | ||
| key=lambda x: -x["y"], | ||
| )[:30] |
tyilo
reviewed
May 12, 2025
| if player != user: | ||
| played_with_count[player.username] += 1 | ||
|
|
||
| top20 = sorted( |
Member
There was a problem hiding this comment.
Use played_with_count.most_common()
tyilo
reviewed
May 12, 2025
| ({"x": k, "y": v} for k, v in played_with_count.items()), | ||
| key=lambda x: -x["y"], | ||
| )[:30] | ||
| if len(top20) < 20: |
Member
There was a problem hiding this comment.
This logic is wrong. If a player has only ever played with the same 5 players, they should be able to get the base level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.