[PER-170] augmenting calibration positions #191
Merged
khughes-bdai merged 2 commits intomainfrom Jan 16, 2026
Merged
Conversation
Pull Request Test Coverage Report for Build 21039901132Details
💛 - Coveralls |
jbarry-bdai
approved these changes
Jan 16, 2026
khughes-bdai
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we augment the calibration to allow view diversity along the width of the board, i.e., the x axis.
in other words, we can now vary the position of the views taken during collection.
this makes the calibration views configurable. the above change also moves the camera along the width
of the board, not just distance to the board.
Testing: I tested this using my calibration_gui.py.
Here are the configuration parameters is used for this collect:
for the --dist_from_board_viewpoint_range
i used: [0.2, 0.6, 0.15]
and for --dist_along_board_width
i used: [-0.3, 0.4, 0.2]
which, if you collection is taken with spot about 1.5 meters away from the board, i get over 300 views.
to understnad the error of calibration, i took 4 collects, and here are the estimates of the translation between the RGB and depth frames:
Here, you can see something typical for calibration, the error on the x,y values are about a millimeter, but the error for the z values are about a centimeter.
Please note that when with the current set of views (on main), the error is far greater. i am getting about 10 centimeters in the z direction