Add @react-aria/datepicker and @react-aria/i18n dependencies#660
Merged
mkernohanbc merged 1 commit intomainfrom Apr 20, 2026
Merged
Add @react-aria/datepicker and @react-aria/i18n dependencies#660mkernohanbc merged 1 commit intomainfrom
mkernohanbc merged 1 commit intomainfrom
Conversation
ty2k
added
Dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #659.
These React component library dependencies are not new, and are already present in
package-lock.jsonand used byDatePicker. I've added them at the exact version they are currently at (642ea27) as opposed to the latest versions from the April React Aria v1.17.0 release. I find if I use the latest versions of these dependencies, many tests no longer pass due to missing requirements fromreact-aria-componentsv1.17.0. I think it's best to upgrade RAC and those dependencies in a separate PR after this is merged.I'm using
dependenciesinstead ofdevDependenciesbecause these needs to be shipped with the component library, as theDatePickerrelies directly on them. Contrast that with something like@react-stately/datawhich appears indevDependenciesbecause it is only used for our Vite kitchen sink app and not shipped with the component library.Once this is in place, it will simplify #657 a bit.