Open
Conversation
mkernohanbc
added
the
Components
ty2k
approved these changes
Apr 18, 2026
Contributor
ty2k
left a comment
ty2k
left a comment
There was a problem hiding this comment.
Super cool! 🦾 🤖
I don't have a way to test this with the full Figma integration, but I've tested that:
- All scripts still run as expected
- All tests still pass
- No linting or formatting issues
- No change to the distributed code after running
build(ex: to make sure the code from the*.figma.tsxfiles doesn't accidentally end up in the dist bundle)
There are no blockers to merging here, but I have a couple of things to note below. Also, can we please add a line or two to the README to point out what these files are for?
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "codeConnect": { | |||
| "include": ["**/*.figma.ts", "src/components/**/*.tsx"], | |||
Contributor
There was a problem hiding this comment.
I see **/*.figma.ts in the include globs here, but no new files that would match this pattern. I think this is auto-generated, so just pointing this out.
| "react-dom": "^16.14.0 || ^17.0.0-rc.1 || ^18.0.0 || ^19.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@figma/code-connect": "^1.4.3", |
Contributor
There was a problem hiding this comment.
Can we please pin this to just "1.4.3" to match the pinning for the rest of the devDependencies?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts the process of implementing Figma's Code Connect API (see #430). It adds
*.figma.tsxfiles containing mappings between React props and Figma props alongside each component. It does not touch component files themselves.Initial mappings were auto-generated using Figma's migration script, and then manually checked. This process has surfaced various inconsistencies between component and implementation in Figma and React (for example, inverted booleans and type mismatches.) These will be addressed in subsequent PRs.
Figma does not provide a method to test Code Connect implementation on a branch, so the next steps will be to: