crate_universe: error on empty host triples in cargo tree resolver#3979
Merged
illicitonion merged 1 commit intobazelbuild:mainfrom Apr 19, 2026
Merged
Conversation
When `supported_platform_triples` contained no platforms with host tools, `TreeResolver::execute_cargo_tree` would silently produce no `cargo tree` output, and `crate_universe` would generate BUILD files with empty `crate_features` and no optional dependencies. Bail with an actionable error instead, pointing the user at adding Bazel's execution platform triple to `supported_platform_triples`. Fixes bazelbuild#3907
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
supported_platform_triplescontained no platforms with host tools,TreeResolver::execute_cargo_treewould silently produce nocargo treeoutput, andcrate_universewould generate BUILD files with emptycrate_featuresand no optional dependencies. Bail with an actionable error instead, pointing the user at adding Bazel's execution platform triple tosupported_platform_triples.Fixes #3907