Skip to content

Fix GitHub Pages docs asset paths#9

Merged
JosunLP merged 3 commits intomainfrom
copilot/fix-gh-page-assets-styles
Mar 24, 2026
Merged

Fix GitHub Pages docs asset paths#9
JosunLP merged 3 commits intomainfrom
copilot/fix-gh-page-assets-styles

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

  • Review the new PR feedback and inspect the current docs config/test changes from the last two commits
  • Update the docs base-path logic so local docs builds/dev use / while GitHub Pages builds still use the repo-scoped path
  • Make the docs config test deterministic by controlling env inputs instead of depending on the ambient environment
  • Run targeted validation for the updated docs config and docs build, then capture a docs screenshot
  • Run final review and security checks, push the follow-up commit, and reply on the PR thread

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Copilot AI and others added 2 commits March 24, 2026 15:08
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bQuery/ui/sessions/cd21d1b0-1a06-4652-9c77-c99cdd62bd30
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bQuery/ui/sessions/cd21d1b0-1a06-4652-9c77-c99cdd62bd30
@JosunLP JosunLP marked this pull request as ready for review March 24, 2026 15:15
Copilot AI review requested due to automatic review settings March 24, 2026 15:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the VitePress docs configuration to generate correct asset URLs when deployed to GitHub Pages project sites (repo-scoped paths), and adds a small regression test around the docs config.

Changes:

  • Derive VitePress base from process.env.GITHUB_REPOSITORY (fallback /ui/) to fix GitHub Pages asset resolution.
  • Remove the docs theme logo entry that pointed at a non-existent /logo.svg.
  • Add a Bun test to prevent regressions in docs base-path and missing-logo behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/.vitepress/config.ts Computes a repository-scoped base for GitHub Pages and removes the missing logo reference.
tests/docs-config.test.ts Adds a regression test validating the docs base value and absence of the logo reference.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JosunLP
Copy link
Copy Markdown
Contributor

JosunLP commented Mar 24, 2026

@copilot apply changes based on the comments in this thread

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 24, 2026

@copilot apply changes based on the comments in this thread

Applied in 024b1f0. The docs base now resolves to / for local builds/dev, keeps the repo-scoped path for GitHub Actions/GitHub Pages, and the regression test now uses deterministic env inputs instead of relying on ambient env state. Screenshot: https://github.com/user-attachments/assets/ab6acbe6-1ed6-410f-9343-84cbfe71aed5

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JosunLP JosunLP merged commit 4862b0c into main Mar 24, 2026
10 checks passed
@JosunLP JosunLP deleted the copilot/fix-gh-page-assets-styles branch March 24, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants