Conversation
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/cd21d1b0-1a06-4652-9c77-c99cdd62bd30
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/cd21d1b0-1a06-4652-9c77-c99cdd62bd30
There was a problem hiding this comment.
Pull request overview
Adjusts the VitePress docs configuration to generate correct asset URLs when deployed to GitHub Pages project sites (repo-scoped paths), and adds a small regression test around the docs config.
Changes:
- Derive VitePress
basefromprocess.env.GITHUB_REPOSITORY(fallback/ui/) to fix GitHub Pages asset resolution. - Remove the docs theme
logoentry that pointed at a non-existent/logo.svg. - Add a Bun test to prevent regressions in docs base-path and missing-logo behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/.vitepress/config.ts | Computes a repository-scoped base for GitHub Pages and removes the missing logo reference. |
| tests/docs-config.test.ts | Adds a regression test validating the docs base value and absence of the logo reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/24bfda23-9a9b-4168-bfd4-ca2fe085b9cb
Applied in 024b1f0. The docs base now resolves to |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
/while GitHub Pages builds still use the repo-scoped path📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.