Conversation
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/7d7afef3-07c2-4fd0-af32-83cb01c37c1e
There was a problem hiding this comment.
Pull request overview
Adds a new bq-segmented-control form/selection primitive and improves bq-dropdown-menu keyboard ergonomics (typeahead), along with documentation and Storybook coverage to integrate both into the library’s component surface area.
Changes:
- Introduces
bq-segmented-controlwith radiogroup semantics, roving tab stop behavior, and native form submission via the hidden-input proxy. - Adds printable-key typeahead navigation to
bq-dropdown-menu, clearing its buffer on close/disconnect. - Expands docs/Storybook: new segmented control docs + story, dropdown menu keyboard docs update, new architecture/roadmap page, and docs nav updates.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/segmented-control.test.ts | Adds component tests for segmented control accessibility, default selection, events, and roving tabindex. |
| tests/dropdown-menu.test.ts | Adds regression test for dropdown menu printable-key typeahead focus behavior. |
| stories/segmented-control.stories.ts | Adds Storybook stories/controls for segmented control variants (size/full-width). |
| src/index.ts | Registers segmented control in the global component entry map. |
| src/components/segmented-control/index.ts | Adds component entry export for segmented control. |
| src/components/segmented-control/BqSegmentedControl.ts | Implements the segmented control component (a11y, keyboard, form proxy, styling). |
| src/components/index.ts | Ensures segmented control is included in the side-effect component import bundle. |
| src/components/dropdown-menu/BqDropdownMenu.ts | Implements typeahead buffer + matching logic and cleanup. |
| docs/guide/architecture-roadmap.md | Adds architecture/gap-analysis/roadmap guide page. |
| docs/components/segmented-control.md | Adds segmented control documentation (API, a11y, keyboard, theming). |
| docs/components/index.md | Adds segmented control to the component catalog. |
| docs/components/dropdown-menu.md | Documents typeahead keyboard behavior for dropdown menu. |
| docs/.vitepress/config.ts | Updates docs navigation (GitHub link + new guide page + component sidebar entry). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/770510b0-8b29-4fa8-97eb-87baea7559ee
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/770510b0-8b29-4fa8-97eb-87baea7559ee
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/770510b0-8b29-4fa8-97eb-87baea7559ee
…ariable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…tion or class' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/770510b0-8b29-4fa8-97eb-87baea7559ee
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/770510b0-8b29-4fa8-97eb-87baea7559ee
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/770510b0-8b29-4fa8-97eb-87baea7559ee
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/770510b0-8b29-4fa8-97eb-87baea7559ee
Applied the review-thread follow-up in f477e1e. The duplicate host |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Agent-Logs-Url: https://github.com/bQuery/ui/sessions/e380cf01-78f7-4f17-b67c-f6d334126a56
Applied the follow-up in 334874f. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
getComputedStyle⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.