Skip to content

Update ggl.local-deployment.service dependency to ggdeploymentd only#15247

Open
rawalexe wants to merge 2 commits intoaws4embeddedlinux:master-nextfrom
rawalexe:update-local-deployment-service
Open

Update ggl.local-deployment.service dependency to ggdeploymentd only#15247
rawalexe wants to merge 2 commits intoaws4embeddedlinux:master-nextfrom
rawalexe:update-local-deployment-service

Conversation

@rawalexe
Copy link
Copy Markdown
Contributor

@rawalexe rawalexe commented Mar 7, 2026

Also removed the 10 second delay

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rawalexe rawalexe requested a review from a team as a code owner March 7, 2026 00:53
@rawalexe rawalexe changed the base branch from master to master-next March 7, 2026 00:56
@rawalexe rawalexe force-pushed the update-local-deployment-service branch from 077c27a to ef00ca9 Compare March 7, 2026 00:56
@rpcme rpcme deleted the branch aws4embeddedlinux:master-next March 9, 2026 17:26
@rpcme rpcme closed this Mar 9, 2026
@rpcme rpcme reopened this Mar 9, 2026
@rpcme rpcme added this pull request to the merge queue Mar 21, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2026
@rpcme rpcme added this pull request to the merge queue Mar 21, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2026
@rpcme rpcme marked this pull request as draft March 21, 2026 12:21
@rpcme
Copy link
Copy Markdown
Member

rpcme commented Mar 21, 2026

I have moved this PR to draft until the point of the dependent greengrass lite release.

@rpcme rpcme marked this pull request as ready for review March 25, 2026 13:26
@patrzhan patrzhan force-pushed the update-local-deployment-service branch from 8138d29 to c774d39 Compare April 3, 2026 23:35
ggdeploymentd now uses sd_notify to signal readiness (v2.4.0), so
After=ggl.core.ggdeploymentd.service is sufficient. The sleep 10 hack
and dependency on greengrass-lite.target/fleet-provisioning are no
longer needed.

Fixes: aws4embeddedlinux#15159
Co-authored-by: Anubhav Rawal <anubhavrawal00@gmail.com>
@patrzhan patrzhan force-pushed the update-local-deployment-service branch from c774d39 to b543a36 Compare April 3, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants