fix: clamp gather indices in diag 1D→2D for non-zero k#54
Open
ymwangg wants to merge 1 commit intoaws-neuron:mainfrom
Open
fix: clamp gather indices in diag 1D→2D for non-zero k#54ymwangg wants to merge 1 commit intoaws-neuron:mainfrom
ymwangg wants to merge 1 commit intoaws-neuron:mainfrom
Conversation
When k != 0, the output matrix is (n, n) where n = len(v) + |k|, but the iota indices range [0, n) while v only has len(v) elements. The compiler rejects the out-of-bounds gather even though those positions are masked to zero. Clamping to [0, len(v)-1] before take fixes this. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
k != 0,np.diag(1D→2D path) builds an(n, n)output wheren = len(v) + |k|, but the iota gather indices range[0, n)whilevonly haslen(v)elementswhere(diag_mask, ...)idx_refto[0, len(v) - 1]beforetakeso the gather stays in-boundsTest plan
test_diag_1d_to_2d_negative_know passes (was failing withNCC_EVRF056OOB error)test_diag_1d_to_2d,test_diag_2d_to_1d,test_diagonal_gather) still pass🤖 Generated with Claude Code