[ty] Fix TODO for meta-type of intersections#24761
Draft
AlexWaygood wants to merge 1 commit intomainfrom
Draft
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.94%. The percentage of expected errors that received a diagnostic held steady at 83.36%. The number of fully passing files held steady at 79/133. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownsphinx
prefect
trio
flake8
|
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
unused-type-ignore-comment |
22 | 3 | 0 |
unknown-argument |
12 | 0 | 0 |
too-many-positional-arguments |
9 | 0 | 0 |
invalid-argument-type |
4 | 0 | 1 |
invalid-return-type |
3 | 0 | 0 |
invalid-assignment |
1 | 1 | 0 |
missing-argument |
1 | 0 | 0 |
no-matching-overload |
1 | 0 | 0 |
possibly-missing-attribute |
1 | 0 | 0 |
| Total | 54 | 4 | 1 |
Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.
Raw diff (59 changes)
bokeh (https://github.com/bokeh/bokeh)
+ src/bokeh/embed/standalone.py:287:28 error[too-many-positional-arguments] Too many positional arguments to `Model.__init__`: expected 1, got 2
+ src/bokeh/embed/standalone.py:287:28 error[too-many-positional-arguments] Too many positional arguments to `object.__init__`: expected 1, got 2
discord.py (https://github.com/Rapptz/discord.py)
+ discord/ext/commands/core.py:1183:16 warning[possibly-missing-attribute] Attribute `__cog_name__` may be missing on object of type `type[CogT@Command] & ~<class 'NoneType'>`
+ discord/ui/view.py:952:17 error[invalid-assignment] Invalid subscript assignment with key of type `Pattern[str]` and value of type `type[Item[Any]] & type[DynamicItem[object]]` on object of type `dict[Pattern[str], type[DynamicItem[Item[Any]]]]`
koda-validate (https://github.com/keithasaurus/koda-validate)
+ koda_validate/namedtuple.py:130:43 error[invalid-argument-type] Argument to function `signature` is incorrect: Expected `(...) -> Any`, found `type[_NTT@NamedTupleValidator]`
mitmproxy (https://github.com/mitmproxy/mitmproxy)
- test/mitmproxy/proxy/tutils.py:354:25 error[invalid-argument-type] Method `__getitem__` of type `bound method dict[Command, type[CommandCompleted]].__getitem__(key: Command, /) -> type[CommandCompleted]` cannot be called with key of type `type[@Todo]` on object of type `dict[Command, type[CommandCompleted]]`
+ test/mitmproxy/proxy/tutils.py:354:25 error[invalid-argument-type] Method `__getitem__` of type `bound method dict[Command, type[CommandCompleted]].__getitem__(key: Command, /) -> type[CommandCompleted]` cannot be called with key of type `type[Command]` on object of type `dict[Command, type[CommandCompleted]]`
operator (https://github.com/canonical/operator)
- ops/model.py:1908:69 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/dtypes/concat.py:126:17 error[unknown-argument] Argument `axis` does not match any known parameter of bound method `ExtensionArray._concat_same_type`
+ pandas/core/sorting.py:613:37 error[too-many-positional-arguments] Too many positional arguments to `object.__init__`: expected 1, got 2
psycopg (https://github.com/psycopg/psycopg)
+ psycopg/psycopg/rows.py:137:16 error[invalid-return-type] Return type does not match returned value: expected `RowMaker[tuple[object, ...] & NamedTupleLike]`, found `bound method type[NamedTupleLike]._make(iterable: Iterable[Any]) -> NamedTupleLike`
+ psycopg/psycopg/rows.py:145:12 error[invalid-return-type] Return type does not match returned value: expected `type[tuple[object, ...]] & type[NamedTupleLike]`, found `<class 'Row'>`
+ psycopg/psycopg/types/composite.py:512:12 error[invalid-return-type] Return type does not match returned value: expected `type[tuple[object, ...]] & type[NamedTupleLike]`, found `<class '<unknown>'>`
rotki (https://github.com/rotki/rotki)
+ rotkehlchen/tasks/historical_balances.py:551:36 error[missing-argument] No argument provided for required parameter `group_identifier` of `HistoryBaseEntry.__init__`
+ rotkehlchen/tasks/historical_balances.py:552:17 error[unknown-argument] Argument `tx_ref` does not match any known parameter of `HistoryBaseEntry.__init__`
+ rotkehlchen/tasks/historical_balances.py:552:17 error[invalid-argument-type] Argument to `OnchainEvent.__init__` is incorrect: Expected `Never`, found `object`
+ rotkehlchen/tasks/historical_balances.py:562:17 error[unknown-argument] Argument `counterparty` does not match any known parameter of `HistoryBaseEntry.__init__`
+ rotkehlchen/tasks/historical_balances.py:563:17 error[unknown-argument] Argument `address` does not match any known parameter of `HistoryBaseEntry.__init__`
+ rotkehlchen/tasks/historical_balances.py:563:17 error[invalid-argument-type] Argument to `OnchainEvent.__init__` is incorrect: Expected `None`, found `object`
scipy (https://github.com/scipy/scipy)
+ scipy/sparse/_index.py:54:43 error[too-many-positional-arguments] Too many positional arguments to `object.__init__`: expected 1, got 2
+ scipy/sparse/_index.py:54:43 error[too-many-positional-arguments] Too many positional arguments to `object.__init__`: expected 1, got 2
+ scipy/sparse/_index.py:54:50 error[unknown-argument] Argument `shape` does not match any known parameter of `object.__init__`
+ scipy/sparse/_index.py:54:50 error[unknown-argument] Argument `shape` does not match any known parameter of `object.__init__`
+ scipy/sparse/_index.py:54:67 error[unknown-argument] Argument `dtype` does not match any known parameter of `object.__init__`
+ scipy/sparse/_index.py:54:67 error[unknown-argument] Argument `dtype` does not match any known parameter of `object.__init__`
+ scipy/sparse/_index.py:56:43 error[too-many-positional-arguments] Too many positional arguments to `object.__init__`: expected 1, got 2
+ scipy/sparse/_index.py:56:43 error[too-many-positional-arguments] Too many positional arguments to `object.__init__`: expected 1, got 2
+ scipy/sparse/_index.py:56:52 error[unknown-argument] Argument `shape` does not match any known parameter of `object.__init__`
+ scipy/sparse/_index.py:56:52 error[unknown-argument] Argument `shape` does not match any known parameter of `object.__init__`
+ scipy/sparse/_index.py:56:69 error[unknown-argument] Argument `dtype` does not match any known parameter of `object.__init__`
+ scipy/sparse/_index.py:56:69 error[unknown-argument] Argument `dtype` does not match any known parameter of `object.__init__`
scrapy (https://github.com/scrapy/scrapy)
+ scrapy/utils/python.py:268:27 error[too-many-positional-arguments] Too many positional arguments to `object.__init__`: expected 1, got 2
sphinx (https://github.com/sphinx-doc/sphinx)
+ sphinx/domains/std/__init__.py:1392:26 error[no-matching-overload] No overload of bound method `dict.get` matches arguments
static-frame (https://github.com/static-frame/static-frame)
+ static_frame/core/container_util.py:1521:34 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/container_util.py:1523:71 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/container_util.py:1536:17 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/index.py:334:54 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/index.py:1946:34 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/index_hierarchy.py:2154:70 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/index_hierarchy.py:2155:41 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/index_hierarchy.py:2160:75 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/index_hierarchy.py:2165:60 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/index_hierarchy.py:2166:44 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/index_hierarchy.py:2169:42 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/index_hierarchy.py:2173:57 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/index_hierarchy.py:2179:31 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
- static_frame/core/quilt.py:856:58 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
- static_frame/core/quilt.py:862:46 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
- static_frame/core/type_blocks.py:3350:34 error[invalid-assignment] Object of type `GeneratorType[(Iterable[Any] & ~TypeBlocks) | ndarray[Any, Any], None, None]` is not assignable to `Iterable[ndarray[Any, Any]]`
+ static_frame/core/type_blocks.py:3347:75 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/type_blocks.py:3351:36 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/type_blocks.py:3352:70 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/type_blocks.py:3355:86 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/type_blocks.py:3356:69 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/type_blocks.py:3360:123 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/type_blocks.py:3362:73 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/type_blocks.py:3365:43 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/core/type_blocks.py:3370:127 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
+ static_frame/test/unit/test_quilt.py:2111:45 error[invalid-argument-type] Argument to bound method `Quilt._axis_tuple` is incorrect: Expected `(type[tuple[object, ...]] & type[NamedTupleLike]) | None`, found `<class 'tuple'>`
sympy (https://github.com/sympy/sympy)
+ sympy/physics/quantum/spin.py:1028:21 error[too-many-positional-arguments] Too many positional arguments to constructor `SpinState.__new__`: expected 3, got 4
AlexWaygood
force-pushed
the
alex/inter-todo
branch
from
84a4fa7 to
fd2fc0d
Compare
Member
Author
Ecosystem analysis (WIP)Here's a minimized version of the bokeh hits Detailsfrom typing import Any, Sequence
class Model: ...
def f(
models: Model | dict[str, Model],
x: dict[object, object],
y: list[str],
):
dict_type: type[dict[Any, Any]] = dict
if isinstance(models, dict):
# (Model & Top[dict[Unknown, Unknown]]) | dict[str, Model]
reveal_type(models)
# (type[Model] & type[Top[dict[Unknown, Unknown]]]) | type[dict[str, Model]]
reveal_type(models.__class__)
dict_type = models.__class__
# <class 'dict'> | (type[Model] & type[Top[dict[Unknown, Unknown]]]) | type[dict[str, Model]]
reveal_type(dict_type)
# error[no-matching-overload] No overload of `dict.__init__` matches arguments
# error[no-matching-overload] No overload of `dict.__init__` matches arguments
# error[too-many-positional-arguments] Too many positional arguments to `object.__init__`: expected 1, got 2
dict_type(zip(x.keys(), y))On This feels like yet another instance where our narrowing-via-intersections behaviour is strictly correct, but will likely be quite confusing for our users. Still, this behaviour is consistent with our behaviour elsewhere, so it's not really a bug in this PR. A minimized version of the from typing import NamedTuple, Callable, Any
def f[T: NamedTuple](x: type[T], y: NamedTuple) -> type[T]:
reveal_type(x) # type[T@f]
reveal_type(y) # tuple[object, ...] & NamedTupleLike
# error[invalid-assignment] Object of type `type[T@f]` is not assignable to `(...) -> Any`
z: Callable[..., Any] = x
return xThis is weird and seems indicative of another intersection-related bug somewhere in the codebase; I'll take a look... The pandas hits look similar to the bokeh hits, and they already have The psycopg hits minimize to this: from typing import NamedTuple, Any, Sequence, Protocol
class RowMaker[Row: tuple[Any, ...]](Protocol):
def __call__(self, values: Sequence[Any], /) -> Row: ...
def namedtuple_row(namedtuple_cls: type[NamedTuple]) -> RowMaker[NamedTuple]:
# error[invalid-return-type] Return type does not match returned value: expected `RowMaker[tuple[object, ...] & NamedTupleLike]`, found `bound method type[NamedTupleLike]._make(iterable: Iterable[Any]) -> NamedTupleLike`
return namedtuple_cls._makeIf this PR is rebased on #24770, we get And a minimal repro of this that demonstrates the issue on from ty_extensions import Intersection
from typing import Self, reveal_type
class Bar:
def method(self) -> Self:
return self
class Foo: ...
def f(x: Intersection[Bar, Foo]):
reveal_type(x.method()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan