[ty] Defer union of parameter types#24756
Merged
charliermarsh merged 2 commits intomainfrom Apr 21, 2026
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.94%. The percentage of expected errors that received a diagnostic held steady at 83.36%. The number of fully passing files held steady at 79/133. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
trio
sphinx
prefect
|
Merging this PR will improve performance by ×17
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | ty_micro[vararg_parameter_type_accumulation] |
4,875.3 ms | 282.8 ms | ×17 |
| ⚡ | Simulation | ty_micro[gradual_vararg_call] |
4,871.2 ms | 287.2 ms | ×17 |
| ⚡ | Memory | ty_micro[gradual_vararg_call] |
162.1 MB | 34.5 MB | ×4.7 |
| ⚡ | Memory | ty_micro[vararg_parameter_type_accumulation] |
161 MB | 33.4 MB | ×4.8 |
Comparing charlie/ty-1393-performance-iii (93501b2) with charlie/ty-1393-performance-i (c474889)
Footnotes
-
60 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On main, given a variadic argument like
*args, we construct an accumulated union of all parameters passed to the call, updating that union one-by-one as we go. So for each argument, we rebuild the union.Now, we store a union builder per parameter, and build those unions at the end.