Conversation
- Add Student Name + Pronouns fields (He/Him, She/Her, They/Them, Prefer not to answer)
- Add getPronouns() helper returning subj/obj/poss/subjCap/is/has pronoun set
- Add fillTemplate() helper to replace {P_*} tokens throughout letter text
- Update TRANSITIONS, TRAIT_PHRASES, OPENINGS, CLOSINGS with {P_*} tokens
- Update PURPOSE_DATA closingStatements with {P_*} tokens
- Update buildTraitParagraph() to accept and apply pronoun object
- Update generateLetter() to read/validate pronouns and pass p to all templates
- Update clearBtn to reset pronouns dropdown
- Fix 'stand apart from them' (teammates ref) to avoid ambiguous pronoun replacement
- All four pronoun options verified: he/him, she/her, they/them, prefer (name-based)
Agent-Logs-Url: https://github.com/aspiece/GCI/sessions/d969be66-bc32-4504-8bb2-ff7499661c4f
Co-authored-by: aspiece <1187774+aspiece@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aspiece/GCI/sessions/d969be66-bc32-4504-8bb2-ff7499661c4f Co-authored-by: aspiece <1187774+aspiece@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
aspiece
April 29, 2026 17:01
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a required Pronouns field to the letter generator form and threads the selected pronouns through every generated paragraph so letters read as personally written for the specific student.
Form Changes
pronounSelectdropdown (required, positioned after name fields): He/Him, She/Her, They/Them, Prefer not to answerPronoun Engine
getPronouns(selection, firstName)→ returns{ subj, obj, poss, subjCap, is, has, … }. For Prefer not to answer, all pronoun slots resolve tofirstName/firstName + "'s"— no pronouns ever surface in the output.fillTemplate(text, firstName, p)— replaces{P_SUBJ},{P_OBJ},{P_POSS},{P_SUBJ_CAP},{P_IS},{P_HAS}tokens in any string.Template Updates
All student-referencing
they/them/theirreplaced with{P_*}tokens across:TRANSITIONS, all 15TRAIT_PHRASESentries,OPENINGS(×7),CLOSINGS(×6),PURPOSE_DATAclosingStatements (all 7 purposes)buildTraitParagraph()now accepts and appliespgenerateLetter()reads/validates pronouns, constructsp, passes it to every templateOne existing phrase — "a consistent effort to lift teammates up rather than stand apart from them" — was rewritten to remove the ambiguous
them(referred to teammates, not the student) to prevent incorrect substitution.