Merged
Conversation
samuelburnham
force-pushed
the
ci-valgrind
branch
from
317bfad to
fcd357f
Compare
arthurpaulino
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FFI tests don't need
get_env!, but it's currently called on all tests. When Lean modules are imported as compact regions they are not explicitly freed by the Lean runtime in favor of letting the OS free this memory more efficiently. This appears as a leak in Valgrind despite it being intended behavior, so this PR removesget_env!from the FFI test path which runs under Valgrind.Successful run: https://github.com/argumentcomputer/ix/actions/runs/24248431304