SSA: More controlled stack growing in shuffler#16603
Merged
Conversation
Previously, when growing the current stack, we would always grow if we can put a slot on top that is expected there in the target. However, if we have something in the args that still need to be fixed and would go out of reach, we should skip this step and focus on fixing the deep arg first. This also fixes the last cycling behaviour in our tests.
blishko
force-pushed
the
ssa-fix-shuffler-cycling
branch
from
f18c469 to
6b61167
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when growing the current stack, we would always grow if we can put a slot on top that is expected there in the target.
However, if we have something in the args that still need to be fixed and would go out of reach, we should skip this step and focus on fixing the deep arg first.
This also fixes the last cycling behaviour in our tests.