arduino: add Kconfig for delayMicroseconds() compensation#437
Open
soburi wants to merge 1 commit intoarduino:mainfrom
Open
arduino: add Kconfig for delayMicroseconds() compensation#437soburi wants to merge 1 commit intoarduino:mainfrom
soburi wants to merge 1 commit intoarduino:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a configurable compensation value for delayMicroseconds() to better account for software overhead and improve short-delay accuracy in the Arduino-on-Zephyr core.
Changes:
- Adds
CONFIG_ARDUINO_DELAY_US_COMPENSATIONKconfig option (default1µs). - Updates
delayMicroseconds()to subtract the configured compensation and adds guards for small delays.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
cores/arduino/inlines.h |
Applies a configurable compensation value when calling k_busy_wait() for delayMicroseconds(). |
Kconfig |
Introduces the new ARDUINO_DELAY_US_COMPENSATION Kconfig symbol and help text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
soburi
force-pushed
the
delay_us_compensation
branch
from
1d16cc6 to
f8909da
Compare
Add CONFIG_ARDUINO_DELAY_US_COMPENSATION for generalize the delayMicroseconds() compensation. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi
force-pushed
the
delay_us_compensation
branch
from
f8909da to
2570818
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Built
|
| Artifact | Board | Core | Tests | RAM | Sketches | Warnings | Errors |
|---|---|---|---|---|---|---|---|
✅ zephyr_contrib |
ek_ra8d1
| 📗 | ✅ |
11.9% |
2 | - | - |
frdm_mcxn947
| 6 🏷️ | ✅ |
58.0% |
2 | - | - | |
frdm_rw612
| 1 🏷️ | ✅ |
83.0% |
2 | - | - | |
✔️* zephyr_main |
giga
| 4 🏷️ | ✅* |
54.6% |
56 | 12 | - |
nano33ble
| 1 🏷️ | ✅* |
78.8% |
28 | 10 | - | |
nano_matter
| 📗 | ✔️* |
|
20 | 8 | (2*) | |
nicla_vision
| 4 🏷️ | ✔️* |
56.9% |
50 | 12 | (10*) | |
niclasense
| 2 🏷️ | ✅* |
|
26 | 10 | - | |
opta
| 4 🏷️ | ✅* |
56.5% |
60 | 26 | - | |
portentac33
| 3 🏷️ | ✔️* |
|
62 | 26 | (8*) | |
portentah7
| 3 🏷️ | ✅* |
57.2% |
70 | 26 | - | |
✅* zephyr_unoq |
unoq
| 📗 | ✅* |
26.9% |
74 | 8 | - |
Legend
Board Test Status description 🔥 🔥 Test run failed to complete. ❌ 🔴 Test completed with unexpected errors. ✔️* 🚫 Test completed with errors, but all are known/expected. ✅* 🟡 Test completed with some warnings; no errors detected. ✅ 🟢 Test passed successfully, with no warnings or errors. 🌑 🌑 Test was skipped.
|
Memory usage change @ 2570818
Click for full report table
Click for full report CSV |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CONFIG_ARDUINO_DELAY_US_COMPENSATION for
generalize the delayMicroseconds() compensation.