Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates multiple Zephyr sample CMakeLists.txt files to locate the correct board “variant” directory and device-tree overlay file more flexibly, including support for board-revision-specific variant/overlay naming.
Changes:
- Add variant directory selection logic with fallbacks (
${NORMALIZED_BOARD_TARGET}_${BOARD_REVISION}→${NORMALIZED_BOARD_TARGET}→${BOARD}). - Add overlay selection logic with fallbacks (
${NORMALIZED_BOARD_TARGET}_${BOARD_REVISION}.overlay→${NORMALIZED_BOARD_TARGET}.overlay→${BOARD}.overlay). - Apply the same overlay-resolution pattern across multiple samples.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/threads_arduino/CMakeLists.txt | Add variant dir + overlay fallback selection (incl. board revision). |
| samples/spi_controller/CMakeLists.txt | Add variant dir + overlay fallback selection (incl. board revision). |
| samples/serial_event/CMakeLists.txt | Add variant dir + overlay fallback selection (incl. board revision). |
| samples/i2cdemo/CMakeLists.txt | Add variant dir + overlay fallback selection (incl. board revision). |
| samples/hello_arduino/CMakeLists.txt | Add variant dir + overlay fallback selection (incl. board revision). |
| samples/fade/CMakeLists.txt | Add variant dir + overlay fallback selection (incl. board revision). |
| samples/button_press_led/CMakeLists.txt | Add variant dir + overlay fallback selection (incl. board revision). |
| samples/blinky_arduino/CMakeLists.txt | Add variant dir + overlay fallback selection (incl. board revision). |
| samples/attach_interrupt/CMakeLists.txt | Add variant dir + overlay fallback selection (incl. board revision). |
| samples/analog_input/CMakeLists.txt | Add variant dir + overlay fallback selection (incl. board revision). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
Directories and filenames are now searched in the following order:
- ${board}_${qualifier}_${revision}
- ${board}_${qualifier}
- ${board}
Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi
force-pushed
the
samples_path_search_improvement
branch
from
5fccd7f to
dde6fc7
Compare
Built
|
| Artifact | Board | Core | Tests | RAM | Sketches | Warnings | Errors |
|---|---|---|---|---|---|---|---|
✅ zephyr_contrib |
ek_ra8d1
| 📗 | ✅ |
11.9% |
2 | - | - |
frdm_mcxn947
| 6 🏷️ | ✅ |
58.0% |
2 | - | - | |
frdm_rw612
| 1 🏷️ | ✅ |
83.0% |
2 | - | - | |
✔️* zephyr_main |
giga
| 4 🏷️ | ✅* |
54.6% |
56 | 12 | - |
nano33ble
| 1 🏷️ | ✅* |
78.8% |
28 | 10 | - | |
nano_matter
| 📗 | ✔️* |
|
20 | 8 | (2*) | |
nicla_vision
| 4 🏷️ | ✔️* |
56.9% |
50 | 12 | (10*) | |
niclasense
| 2 🏷️ | ✅* |
|
26 | 10 | - | |
opta
| 4 🏷️ | ✅* |
56.5% |
60 | 26 | - | |
portentac33
| 3 🏷️ | ✔️* |
|
62 | 26 | (8*) | |
portentah7
| 3 🏷️ | ✅* |
57.2% |
70 | 26 | - | |
✅* zephyr_unoq |
unoq
| 📗 | ✅* |
26.9% |
74 | 8 | - |
Legend
Board Test Status description 🔥 🔥 Test run failed to complete. ❌ 🔴 Test completed with unexpected errors. ✔️* 🚫 Test completed with errors, but all are known/expected. ✅* 🟡 Test completed with some warnings; no errors detected. ✅ 🟢 Test passed successfully, with no warnings or errors. 🌑 🌑 Test was skipped.
|
Memory usage change @ dde6fc7
Click for full report table
Click for full report CSV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directories and filenames are now searched in the following order:
${board}_${qualifier}_${revision}${board}_${qualifier}${board}