Open
Conversation
To try and purge Foundation from the Linux builds I've been making the rounds on our types. This one is a breaking change, but I'd been wanting to do this for ages. `Terminal` (to me) should be as lightweight as possible and not be tied to any `FileHandle` semantics. I think we should expose the raw fd, but exposing a handle parameter was always a bit odd to me. This change: - Gets rid of the `handle` var. - Keeps `Terminal` a value type, so if you did want some double close protection or synchronization on the type you can decide to wrap it if you need to. - Exposes a `fileDescriptor` public var. - Adds unit tests for Terminal finally..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To try and purge Foundation from the Linux builds I've been making the rounds on our types. This one is a breaking change, but I'd been wanting to do this for ages.
Terminal(to me) should be as lightweight as possible and not be tied to anyFileHandlesemantics. I think we should expose the raw fd, but exposing a handle parameter was always a bit odd to me. This change:handlevar.Terminala value type, so if you did want some double close protection or synchronization on the type you can decide to wrap it if you need to.fileDescriptorpublic var.