Adds journal option to container volume create.#1412
Merged
jglogan merged 1 commit intoapple:mainfrom Apr 22, 2026
Merged
Conversation
github-actions
Bot
added
the
documentation
- Closes apple#1411. - Default behavior doesn't change - with no `journal` option, no journal gets created.
JaewonHur
approved these changes
Apr 22, 2026
|
|
||
| Driver options are passed with `--opt key=value`. The following options are supported for the default `local` driver: | ||
|
|
||
| * `size=<value>`: Volume size with optional unit suffix (K, M, G, T, P). Minimum 1 MiB. Equivalent to `-s`; if `-s` is also specified, `-s` takes precedence. |
Contributor
There was a problem hiding this comment.
Why do we have both -s <s> and this size=<value>?
Contributor
Author
There was a problem hiding this comment.
@realrajaryan for any follow-up on this...
I believe it's just because size should be a driver option (not all volumes will allow you to choose a size; see the PR for SMB/NFS volumes, for example), but for the common case of ext4-backed volumes, it's probably the most useful one for the average user so -s/--size is there for convenience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
container volume create. #1411.journaloption, no journal gets created.Type of Change
Motivation and Context
Should make containers more resilient to ungraceful stops.
Testing