This repository was archived by the owner on Feb 13, 2020. It is now read-only.
Extension to unit tests that demonstrates bug in migration code#487
Open
kristoffermollerhoj wants to merge 1 commit intoapple:masterfrom
Open
Conversation
…econcile migration code. The problem occurs when more than one collection with same ownerUID shared to the migrating user exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem occurs in CrossPodHomeSync.sharedToCollectionsReconcile when more than one collection with same ownerUID shared to the migrating user exists.
More specifically, the problem seems to be located in the function txdav.common.datastore.sql_sharing.SharingHomeMixin.sharedToBindRecords where the dict homeIDs cannot contain more than one value per home id.
Please note that this contribution will make the unit tests fail.