[CI] Add pre-commit workflow with 10+ hooks#294
Open
jbampton wants to merge 2 commits intoapache:masterfrom
Open
[CI] Add pre-commit workflow with 10+ hooks#294jbampton wants to merge 2 commits intoapache:masterfrom
jbampton wants to merge 2 commits intoapache:masterfrom
Conversation
https://github.com/pre-commit/pre-commit-hooks 10 basic checks added to enforce standards, quality an to stop regressions This pre-commit config can be greatly expanded with many more checks in future Examples: https://github.com/apache/sedona/blob/master/.github/workflows/pre-commit.yml https://pre-commit.com/#github-actions-example https://github.com/apache/shiro/blob/main/.github/workflows/pre-commit.yml https://github.com/apache/sedona/blob/master/.pre-commit-config.yaml
Contributor
|
I have some questions:
|
Member
Author
|
Here is another example of a "pre-commit" workflow: https://github.com/apache/tooling-trusted-releases/blob/main/.github/workflows/analyze.yml They use "prek" and uv and pin hashes. We could use this format if needed. When GitHub actions are first added to a repository via a PR they don't run for security reasons. So after this PR is merged they should run on subsequent PRs. cc @dave2wave |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run pre-commit and auto clean up
https://github.com/pre-commit/pre-commit-hooks
10 basic checks added to enforce standards, quality an to stop regressions
This pre-commit config can be greatly expanded with many more checks in future
Examples:
https://github.com/apache/sedona/blob/master/.github/workflows/pre-commit.yml
https://pre-commit.com/#github-actions-example
https://github.com/apache/shiro/blob/main/.github/workflows/pre-commit.yml
https://github.com/apache/sedona/blob/master/.pre-commit-config.yaml