[CI] Remove legacy lint scripts and Apache RAT

[tqchen]

Summary

Remove legacy lint scripts from tests/lint/ that are now redundant with the
pre-commit + ruff workflow. Also remove Apache RAT and Java from the Docker
lint image since ASF header checking is now handled by Python directly.

Changes

• Delete 8 legacy lint scripts (cpplint.sh, pylint.sh, flake8.sh, etc.)
  and their configs (pylintrc, rat-excludes)
• Simplify task_lint.sh and docker/lint.sh to delegate to pre-commit
• Remove RAT/Java install from Dockerfile.ci_lint and legacy pip packages
  (cpplint, pylint, mypy, black, flake8, blocklint)

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the project's CI linting infrastructure. By migrating various standalone linting scripts and their dependencies into the pre-commit framework, it centralizes and simplifies the linting process. This change reduces the number of individual scripts to maintain, streamlines the Docker lint image by removing redundant tools like Apache RAT and several Python packages, and consolidates lint execution under a single, more efficient workflow.

Highlights

• Lint Script Consolidation: Eliminated numerous legacy lint scripts (e.g., cpplint.sh, pylint.sh, flake8.sh) and their configuration files, as their functionality is now handled by the pre-commit and ruff workflow.
• Dependency Reduction: Removed Apache RAT and Java installation from the Docker lint image, along with several Python linting packages (e.g., cpplint, pylint, mypy, black, flake8, blocklint), since ASF header checking and other linting tasks are now managed directly by Python within pre-commit.
• CI Script Simplification: Streamlined task_lint.sh and docker/lint.sh by removing direct calls to individual lint scripts, delegating all linting execution to pre-commit.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• .pre-commit-config.yaml
  • Removed the 'check-file-type' hook.
• docker/Dockerfile.ci_lint
  • Removed installation of 'cpplint', 'pylint', 'mypy', 'black', 'flake8', 'blocklint' Python packages.
  • Removed steps for installing Java and Apache RAT.
• docker/install/ubuntu_install_rat.sh
  • File removed.
• docker/lint.sh
  • Updated 'DEFAULT_STEPS' to only include 'precommit'.
  • Consolidated all legacy lint aliases (e.g., 'cpplint', 'cppdocs', 'docker_format', 'blocklint', 'file_type', 'asf', 'clang_format', 'python_format', 'pylint', 'mypy') to delegate to 'pre-commit run --all-files'.
  • Removed specific 'cpplint', 'cppdocs', 'docker_format', and 'mypy' execution blocks.
• tests/lint/add_asf_header.py
  • File removed.
• tests/lint/check_asf_header.py
  • Updated comment for 'SKIP_LIST' to reflect broader skipping criteria.
• tests/lint/check_file_type.py
  • File removed.
• tests/lint/cppdocs.sh
  • File removed.
• tests/lint/cpplint.sh
  • File removed.
• tests/lint/docker-format.sh
  • File removed.
• tests/lint/pylintrc
  • File removed.
• tests/lint/rat-excludes
  • File removed.
• tests/lint/trailing_newlines.py
  • File removed.
• tests/scripts/task_lint.sh
  • Removed direct calls to 'cppdocs.sh', 'cpplint.sh', and 'docker-format.sh'.
  • Simplified 'shard2' function to explicitly state it's a no-op due to all checks being in 'pre-commit' / 'shard1'.

Activity

• No specific activity (comments, reviews, progress updates) was provided in the context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request provides a great cleanup by removing legacy linting scripts and their dependencies like Apache RAT and Java. Consolidating the linting process into the pre-commit workflow simplifies the CI configuration and improves maintainability. The changes are well-executed and consistent across all modified files, from the Docker image to the CI task scripts. This is a valuable improvement for the project's development infrastructure.