Skip to content

TEZ-4691: Upgrade maven-checkstyle-version to 3.6.0#463

Open
Aggarwal-Raghav wants to merge 1 commit intoapache:masterfrom
Aggarwal-Raghav:TEZ-4691
Open

TEZ-4691: Upgrade maven-checkstyle-version to 3.6.0#463
Aggarwal-Raghav wants to merge 1 commit intoapache:masterfrom
Aggarwal-Raghav:TEZ-4691

Conversation

@Aggarwal-Raghav
Copy link
Contributor

Check TEZ-4691 for details

<build-helper-maven-plugin.version>1.8</build-helper-maven-plugin.version>
<buildnumber-maven-plugin.version>1.1</buildnumber-maven-plugin.version>
<checkstyle.version>8.35</checkstyle.version>
<checkstyle.version>13.3.0</checkstyle.version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't removed puppycrawler explicit dependency as it is present in offical doc as well and based on google maven-checkstyle-version have 9.3 as default puppycrawler version. For now I have moved it to latest 13.3.0.
https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html

@abstractdog
Copy link
Contributor

LGTM, pending tests

@abstractdog abstractdog self-requested a review March 9, 2026 11:06
@Aggarwal-Raghav
Copy link
Contributor Author

Will check the first CI run to confirm if checkstyle fails because of plexus-velocity or not

@Aggarwal-Raghav
Copy link
Contributor Author

@abstractdog , tez CI is asking for login (seeing it for first time). How to login/bypass it?
Screenshot 2026-03-09 at 7 51 44 PM

@abstractdog
Copy link
Contributor

@abstractdog , tez CI is asking for login (seeing it for first time). How to login/bypass it? Screenshot 2026-03-09 at 7 51 44 PM

not sure, have to check what changed on ci-hadoop

I'm monitoring the corresponding job in the meantime, but it's not yet started, because jenkins is about to shut down
Screenshot 2026-03-09 at 15 44 20

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 17m 59s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 11m 40s master passed
+1 💚 compile 3m 16s master passed
+1 💚 javadoc 1m 43s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 54s the patch passed
+1 💚 codespell 2m 14s No new issues.
+1 💚 compile 2m 33s the patch passed
+1 💚 javac 2m 33s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 javadoc 1m 20s the patch passed
_ Other Tests _
+1 💚 unit 73m 31s root in the patch passed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
121m 21s
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-463/1/artifact/out/Dockerfile
GITHUB PR #463
Optional Tests dupname asflicense javac javadoc unit codespell detsecrets xmllint compile
uname Linux 6a5d39947b97 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-agent/workspace/tez-multibranch_PR-463/src/.yetus/personality.sh
git revision master / 7dd38f9
Default Java Ubuntu-21.0.10+7-Ubuntu-124.04
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-463/1/testReport/
Max. process+thread count 1335 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-463/1/console
versions git=2.43.0 maven=3.8.7 codespell=2.4.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants