[fix] Replace printStackTrace() with System.err in CompileReport#1606
Open
Senrian wants to merge 1 commit intoapache:mainfrom
Open
[fix] Replace printStackTrace() with System.err in CompileReport#1606Senrian wants to merge 1 commit intoapache:mainfrom
Senrian wants to merge 1 commit intoapache:mainfrom
Conversation
Replace e.printStackTrace() with System.err.println() to properly log errors to stderr without stack trace noise in CLI tools. Issue: JRException handling in JasperReports compilation
Member
|
Could you create a JIRA ticket? |
Author
|
Created JIRA ticket: https://issues.apache.org/jira/browse/WW-5506 This is a simple code cleanup replacing printStackTrace() with System.err for better logging practice. |
Member
|
@Senrian but the ticket is about file upload issue and not related to Jasper Reports changes |
Author
|
Sorry for the confusion - this PR is indeed a code cleanup (replacing printStackTrace with System.err), not related to file upload. I created a new JIRA ticket for this code cleanup: https://issues.apache.org/jira/browse/WW-5507 |
Member
|
Hm... but this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
e.printStackTrace()withSystem.err.println()to properly log errors to stderr without stack trace noise in CLI tools.Changes
plugins/jasperreports/src/main/java/org/apache/struts2/views/jasperreports/CompileReport.java: Replacee.printStackTrace()withSystem.err.println()for cleaner error outputWhy
Using
printStackTrace()in production code is considered bad practice as it writes directly to stderr without proper logging framework integration. This change usesSystem.err.println()which is more appropriate for CLI tools.