Fix priority issue.Supports lightweight messaging.#1215
Open
zhaohai666 wants to merge 35 commits intoapache:masterfrom
Open
Fix priority issue.Supports lightweight messaging.#1215zhaohai666 wants to merge 35 commits intoapache:masterfrom
zhaohai666 wants to merge 35 commits intoapache:masterfrom
Conversation
- Add LITE = 5 and PRIORITY = 6 to MessageType enum in definition.proto - Align Node.js client with the latest protocol specification - Fix inconsistency between proto definition and generated TypeScript/JS files
- Update protos submodule to include LITE and PRIORITY message types - Sync nodejs proto definition with protocol changes - Ensure npm run init preserves LITE and PRIORITY types
- Update definition.proto to include LITE and PRIORITY message types - Generated from updated protos submodule using npm run init - Ensures Node.js client stays in sync with protocol changes
- Add PRIORITY message type detection in PublishingMessage - Set priority field in toProtobuf method - Validate mutual exclusivity: priority cannot be used with messageGroup, deliveryTimestamp - Ensure transactional messages cannot have priority set - Add ProducerPriorityMessageExample demonstrating priority usage - Align with Java implementation semantics Key changes: 1. PublishingMessage: Detect PRIORITY message type and set it accordingly 2. PublishingMessage.toProtobuf(): Include priority in SystemProperties 3. Message: Validate priority >= 0 and mutual exclusivity constraints 4. Example: Comprehensive demo showing priority levels and validation
- Use (systemProperties as any).setPriority?.() as workaround - Avoids TypeScript error when proto definition hasn't been updated yet - Will work correctly once official proto includes priority field - Maintains backward compatibility
zhaohai666
changed the title
zk-drizzle
reviewed
Apr 9, 2026
zk-drizzle
reviewed
Apr 9, 2026
zk-drizzle
reviewed
Apr 9, 2026
zk-drizzle
reviewed
Apr 9, 2026
zk-drizzle
reviewed
Apr 9, 2026
zk-drizzle
reviewed
Apr 9, 2026
zk-drizzle
reviewed
Apr 9, 2026
zk-drizzle
reviewed
Apr 9, 2026
zk-drizzle
reviewed
Apr 9, 2026
zk-drizzle
reviewed
Apr 9, 2026
zk-drizzle
reviewed
Apr 9, 2026
zk-drizzle
reviewed
Apr 9, 2026
zk-drizzle
reviewed
Apr 10, 2026
zk-drizzle
reviewed
Apr 10, 2026
zk-drizzle
reviewed
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix priority issue.Supports lightweight messaging.