[Java] feat: add empty-queue skip scheduling for SimpleConsumer long-polling#1213
Open
crazywen wants to merge 1 commit intoapache:masterfrom
Open
[Java] feat: add empty-queue skip scheduling for SimpleConsumer long-polling#1213crazywen wants to merge 1 commit intoapache:masterfrom
crazywen wants to merge 1 commit intoapache:masterfrom
Conversation
…polling When using SimpleConsumer with long-polling, if message distribution across queues is uneven (some queues empty, others with messages), the consumer gets blocked by long-polling on empty queues, causing significant delay in receiving messages from queues that actually have data. Enhanced SubscriptionLoadBalancer with empty-queue skip scheduling: - After each receiveMessage call, the result is fed back to the load balancer - Queues that consecutively return empty are temporarily skipped in takeMessageQueue() - Skip duration is proportional to consecutive empty count (capped at 1000 rounds) - When a queue returns messages again, its empty counter resets immediately - Fully backward-compatible: without feedback, behavior is identical to round-robin Co-Authored-By: crazywen <xnxxljw@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When using
SimpleConsumerwith long-polling, if message distribution across queuesis uneven (some queues empty, others with messages), the consumer gets blocked by
long-polling on empty queues, causing significant delay in receiving messages from
queues that actually have data.
This is especially problematic in production with multiple queues where message
traffic is bursty.
Modification
Enhanced
SubscriptionLoadBalancerwith empty-queue skip scheduling:receiveMessagecall, the result (empty or not) is fed back to theSubscriptionLoadBalancerviamarkEmptyResult()/markNonEmptyResult()takeMessageQueue()AtomicIntegerFieldUpdaterfor thread-safe state updatesResult
SubscriptionLoadBalancerType