PROTON-1870 reproducers in Python for overly generic TLS errors#261
Draft
jiridanek wants to merge 6 commits intoapache:mainfrom
Draft
PROTON-1870 reproducers in Python for overly generic TLS errors#261jiridanek wants to merge 6 commits intoapache:mainfrom
jiridanek wants to merge 6 commits intoapache:mainfrom
Conversation
Contributor
Author
|
There is something in the test that starts TLS server in Python that is incompatible with older Python 2.x on Ubuntu, and something in all of the TLS tests that expect Proton TLS to work, that fails on Windows. This issue is on a back burner at this point, so I will not look into fixing this for now. |
jiridanek
force-pushed
the
jd_2020_06_ssl_errors
branch
from
6d58b75 to
6e64e9b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
===========================================
+ Coverage 69.69% 88.34% +18.64%
===========================================
Files 370 47 -323
Lines 69864 2394 -67470
===========================================
- Hits 48695 2115 -46580
+ Misses 21169 279 -20890 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do realize that the tests are extremely similar to the existing TLS tests in Proton Python. It felt much easier to write it gradually from scratch than to fit it into existing test helpers right from the beginning.
This issue may require writing similar tests for all the other bindings.