feat(controller): add lease config and HEARTBEAT support for master l…#387
Open
redwood9 wants to merge 1 commit intoapache:unstablefrom
Open
feat(controller): add lease config and HEARTBEAT support for master l…#387redwood9 wants to merge 1 commit intoapache:unstablefrom
redwood9 wants to merge 1 commit intoapache:unstablefrom
Conversation
…ease - Add LeaseConfig to ControllerConfig (enabled, lease_ms fields) - Add ElectionVersion atomic.Uint64 to Cluster, incremented on PromoteNewMaster - Add LeaseParams and SetLeaseParams to ClusterNode - GetClusterNodeInfo sends CLUSTERX HEARTBEAT when lease is enabled - ClusterChecker.WithLeaseConfig() enables lease-mode probing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the KvRocks split-brain issue (apache/kvrocks#3380)
here is the first step of the proposed solution: Introduce a lease mechanism to KvRocks.
This involves the following changes:
KvRocks side:
Add lease support inside KvRocks
Implement periodic lease refresh (heartbeat) when the feature is enabled
apache/kvrocks#3397
Controller side:
When performing master detection/probing, also fetch and synchronize:
Current master information
Lease-related information (especially lease expiration/TTL)
Add new configuration for lease duration / refresh interval
Lease heartbeat is strictly opt-in via configuration:
If the lease-related config is not set (or explicitly disabled), KvRocks and the controller behave exactly the same as today — no extra overhead, no behavioral change.
Only when the lease feature is explicitly enabled in the config will KvRocks start sending lease refresh heartbeats and the controller will begin comparing master info + lease validity during failover checks.
The detailed commit content: