Improve Scala compilation caching and build config#2967
Open
ribafish wants to merge 6 commits intoapache:masterfrom
Open
Improve Scala compilation caching and build config#2967ribafish wants to merge 6 commits intoapache:masterfrom
ribafish wants to merge 6 commits intoapache:masterfrom
Conversation
…rtifacts and dependencies
Signed-off-by: Gasper Kojek <gkojek@gradle.com>
Signed-off-by: Gasper Kojek <gkojek@gradle.com>
chibenwa
approved these changes
Mar 6, 2026
Contributor
chibenwa
left a comment
There was a problem hiding this comment.
Wonderful contribution 👍
Grateful if you could share build time enhancement metrics!
Contributor
|
Cc @jeantil not sure you have time for this but it will for sure interest you |
Contributor
|
Looks good to me, I had already investigated these changes before after clay pointed out https://github.com/gradle/develocity-build-config-samples/pull/2087/changes to me when I upgraded the extension back I forgot to apply the changes again go (discussion on the ASF slack https://the-asf.slack.com/archives/CF6PY5M4N/p1758051950501649) |
jeantil
reviewed
Mar 6, 2026
| test-run.log | ||
| build | ||
| .mvn/.develocity | ||
| .idea/ |
Contributor
There was a problem hiding this comment.
small nitpick
-
this change is unrelated
-
this local env specific exclusion is more relevant in
$GIT_DIR/info/exclude.- or a configured global ignore file for your user (usually achieved by setting
core.excludesFile)
jeantil
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
sourceDirectoryandtestSourceDirectoryas explicit file inputspluginArtifactsanddependenciesas iterated properties instead of ignoring themcompilerPluginswith IGNORED_PATH normalizationclasspathfrom ignored properties (deprecated, included in classpathElements)Impact
These changes improve Maven build caching accuracy by properly tracking all compilation inputs, reducing unnecessary cache misses during incremental builds.