Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3090 +/- ##
============================================
- Coverage 72.73% 72.69% -0.04%
Complexity 943 943
============================================
Files 1117 1117
Lines 96342 96342
Branches 73541 73559 +18
============================================
- Hits 70070 70032 -38
- Misses 23722 23740 +18
- Partials 2550 2570 +20
🚀 New features to boost your workflow:
|
|
@spetz @hubcio What do you think about this ? we already have the web-ui dashboard that we use for higher fidelity benchmarking visuals. I don't mind this change, but I am not sure whether this should be used only for summary (aggregate results), or for both summary and individual (producer/consumer/consumer_group) results. |
|
IMO looks nice, so as long as it doesn't break anything I think it's a good idea :) |
|
I like this, but i want this behind an argument |
2a5bee8 to
eaf1165
Compare
|
@hubcio I have updated the args |
Motivation
After mass benchmark runs due to
DirectIOPR, I started dreaming about p99 latencies. Woke up screaming. Doctor prescribed tables for readabilityChanges
comfy_tableoutputinfo!()toprintln!())terminal_sizedependency (already in thelockfile)Before
After
wide layout
narrow layout