Skip to content

feat(bench): prettier table output#3090

Open
tungtose wants to merge 2 commits intoapache:masterfrom
tungtose:better-bench-cli-result
Open

feat(bench): prettier table output#3090
tungtose wants to merge 2 commits intoapache:masterfrom
tungtose:better-bench-cli-result

Conversation

@tungtose
Copy link
Copy Markdown
Contributor

@tungtose tungtose commented Apr 8, 2026

Motivation

After mass benchmark runs due to DirectIO PR, I started dreaming about p99 latencies. Woke up screaming. Doctor prescribed tables for readability

Changes

  • Replace log walls with comfy_table output
  • Adaptive layout: vertical on narrow terminals, horizontal on wide (≥140 cols)
  • Fix ANSI colors (switched from info!() to println!())
  • Add terminal_size dependency (already in the lockfile)

Before

image

After

wide layout

image

narrow layout

image

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.69%. Comparing base (af92730) to head (eaf1165).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3090      +/-   ##
============================================
- Coverage     72.73%   72.69%   -0.04%     
  Complexity      943      943              
============================================
  Files          1117     1117              
  Lines         96342    96342              
  Branches      73541    73559      +18     
============================================
- Hits          70070    70032      -38     
- Misses        23722    23740      +18     
- Partials       2550     2570      +20     
Components Coverage Δ
Rust Core 73.44% <ø> (-0.06%) ⬇️
Java SDK 62.30% <ø> (ø)
C# SDK 69.10% <ø> (-0.33%) ⬇️
Python SDK 81.43% <ø> (ø)
Node SDK 91.53% <ø> (+0.21%) ⬆️
Go SDK 38.97% <ø> (ø)
see 25 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@numinnex
Copy link
Copy Markdown
Contributor

numinnex commented Apr 8, 2026

@spetz @hubcio What do you think about this ? we already have the web-ui dashboard that we use for higher fidelity benchmarking visuals.

I don't mind this change, but I am not sure whether this should be used only for summary (aggregate results), or for both summary and individual (producer/consumer/consumer_group) results.

@spetz
Copy link
Copy Markdown
Contributor

spetz commented Apr 10, 2026

IMO looks nice, so as long as it doesn't break anything I think it's a good idea :)

spetz
spetz previously approved these changes Apr 10, 2026
@hubcio
Copy link
Copy Markdown
Contributor

hubcio commented Apr 10, 2026

I like this, but i want this behind an argument --pretty (top level arg, just after executable name).
we often dump logs from iggy-bench to file, and in this file i want all the lines to be acutal logs.

@tungtose
Copy link
Copy Markdown
Contributor Author

@hubcio I have updated the args --pretty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants