GEODE-10556: Fix race condition in PulseSecurityWithSSLTest#7984
Open
JinwooHwang wants to merge 1 commit intoapache:developfrom
Open
GEODE-10556: Fix race condition in PulseSecurityWithSSLTest#7984JinwooHwang wants to merge 1 commit intoapache:developfrom
JinwooHwang wants to merge 1 commit intoapache:developfrom
Conversation
209deba to
3e92b5c
Compare
f993be5 to
0b2beea
Compare
0b2beea to
3b21ac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PulseSecurityWithSSLTestintermittently failed on GitHub Actions with authentication errors (BAD_CREDS) despite using correct credentials. Tests consistently passed locally but failed in CI where JMX/Management Service initialization is slower.Root Cause: Race condition where authentication attempts occurred before ManagementService and MemberMXBean were fully initialized.
Solution
Added synchronization using
GeodeAwaitility.await()to ensure ManagementService is ready before authentication:Applied to both test methods:
loginWithIncorrectAndThenCorrectPasswordloginWithDeprecatedSSLOptionsThis matches the pattern already used in
PulseSecurityIntegrationTest.Testing
Impact
For all changes, please confirm:
develop)?gradlew buildrun cleanly?