[Helm] Create region config for components in value file #2870
Open
hemanthsavasere wants to merge 28 commits intoapache:mainfrom
Open
[Helm] Create region config for components in value file #2870hemanthsavasere wants to merge 28 commits intoapache:mainfrom
hemanthsavasere wants to merge 28 commits intoapache:mainfrom
Conversation
…#2820) * [kv] Support dynamic configuration for 'kv.snapshot.interval' * address yubing's comments
* [helm] Add CI workflow to run Helm tests
…and Array) (apache#2814) * [fluss-client] Add pojo array to fluss array * [fluss-client] Add pojo map to fluss map * [fluss-client] Create shared utilities for POJO type and Fluss type * [fluss-client] Create shared utilities for Fluss type to Pojo type * [fluss-client] Add Fluss array to Pojo array * [fluss-client] Add Fluss map to Pojo map * [ci] Fix Compile Java 8 * Revert _partial_config.mdx * [fluss-client] Hanle primitive arrays * [fluss-client] Refactor PojoMapToFlussMap to follow the same conversion logic as PojoArrayToFlussArray * [fluss-client] Change validateCompatibility logic for MAP and ARRAY types * small fixes and add tests to FlussTypedClient * fix checkstyle * fix checkstyle --------- Co-authored-by: ipolyzos <ipolyzos.se@gmail.com>
…cas-number (apache#2837) * [log] Support dynamic configuration for log.replica.min-in-sync-replicas-number * [log] SSupport dynamic configuration for log.replica.min-in-sync-replicas-number
…he#2842) Co-authored-by: Junfan Zhang <zhangjunfan@qiyi.com>
* [docs] Update doc in api/java-client about complex type * Fix ci
…io.tmpdir` is not set. (apache#2859) Co-authored-by: Junfan Zhang <zhangjunfan@qiyi.com>
…pache#2863) This reverts commit d956e75.
… table managed by Tiering Service (apache#2862)
…ng `coordinator` and `tablet` top-level sections in `values.yaml`, adding `replicas`, `livenessProbe`, `readinessProbe`, and `resources` fields to each. The StatefulSet templates are updated to reference these configurable values instead of hardcoded constants, as per review comments
hemanthsavasere
changed the title
Contributor
|
This issue can be solved in #2871 if the idea is approved. |
affo
approved these changes
Mar 16, 2026
Contributor
affo
left a comment
affo
left a comment
There was a problem hiding this comment.
Crazy good work! I like this a lot, thanks for addressing all my comments in 1 go!
Contributor
|
@swuferhong If that's ok for you, I think we can proceed with this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2472
The Fluss Helm chart had hardcoded values for replica counts, liveness/readiness probe settings, and resource limits for both CoordinatorServer and TabletServer. This made it impossible to tune health probe timings or scale components without directly modifying the chart templates.
This PR consolidates all per-component configuration under the existing
coordinatorandtablettop-level sections invalues.yaml, addingreplicas,livenessProbe,readinessProbe, andresourcesfields to each. The StatefulSet templates are updated to reference these configurable values instead of hardcoded constants.Brief change log
helm/values.yaml: Addedreplicas,livenessProbe,readinessProbe, andresourcesfields under the existingcoordinatorandtabletsections. Removed the top-levelresourcessection (which hadcoordinatorServer/tabletServersub-keys) in favor of co-locating resource config with each component.helm/templates/sts-coordinator.yaml: Replaced hardcodedreplicas: 1and hardcoded probe settings with references to.Values.coordinator.replicas,.Values.coordinator.livenessProbe.*,.Values.coordinator.readinessProbe.*, and.Values.coordinator.resources.helm/templates/sts-tablet.yaml: Replaced hardcodedreplicas: 3and hardcoded probe settings with references to.Values.tablet.replicas,.Values.tablet.livenessProbe.*,.Values.tablet.readinessProbe.*, and.Values.tablet.resources.Default values match the previously hardcoded constants, so existing deployments using default values are unaffected.
Tests
helm template test ./helm— verifies templates render without errorshelm lint ./helm— verifies chart passes lintinghelm template test ./helm --set coordinator.replicas=2 --set tablet.replicas=5to verify custom values are applied correctlyAPI and Format
No changes to Fluss server API or storage format. This is a Helm chart configuration change only.
Documentation
No new Fluss feature is introduced. The change is self-documenting via the updated
values.yamldefaults and comments.