Skip to content

FINERACT-2540: Add unit tests for IpAddressUtils#5631

Open
devi-pathak2263 wants to merge 1 commit intoapache:developfrom
devi-pathak2263:add-ipaddressutils-tests
Open

FINERACT-2540: Add unit tests for IpAddressUtils#5631
devi-pathak2263 wants to merge 1 commit intoapache:developfrom
devi-pathak2263:add-ipaddressutils-tests

Conversation

@devi-pathak2263
Copy link

Description

Description

This PR adds unit tests for the IpAddressUtils utility class.

The tests verify the behavior of the getClientIp() method under different request context scenarios, including:

  • When no request context is available
  • When a request context exists but the IP attribute is missing
  • When a valid IP attribute is present
  • When the IP attribute is a non-string object and must be converted using toString()

These tests improve reliability and increase test coverage for request-related utilities used across the platform.

JIRA: https://issues.apache.org/jira/browse/FINERACT-2540

Testing

Executed locally:

  • ./gradlew spotlessApply
  • ./gradlew :fineract-core:test

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Add unit tests verifying the behavior of getClientIp() under
different request context scenarios including missing request
attributes, missing IP attribute, and valid IP extraction.

These tests improve coverage for request utility helpers used
to retrieve client IP information.
@devi-pathak2263 devi-pathak2263 force-pushed the add-ipaddressutils-tests branch from cca558f to 4da0296 Compare March 16, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant