[fix](filecache) self-heal stale DOWNLOADED entries on local NOT_FOUND#60977
Open
freemandealer wants to merge 1 commit intoapache:masterfrom
Open
[fix](filecache) self-heal stale DOWNLOADED entries on local NOT_FOUND#60977freemandealer wants to merge 1 commit intoapache:masterfrom
freemandealer wants to merge 1 commit intoapache:masterfrom
Conversation
Problem: In a rare restart window, BE can rebuild file-cache metadata in memory while the corresponding cache files are not yet durable on disk. If that metadata is also restored via LRU dump/load, blocks may appear as DOWNLOADED even though the local files are missing. Subsequent reads then produce false-positive cache hits, fail on local read, and repeatedly fall back to S3. This preserves correctness but causes avoidable cache thrashing and latency jitter. Root cause: The read path treated DOWNLOADED as a valid local hit source and fell back to remote reads on failure, but it did not actively invalidate stale metadata when the local cache file was gone. Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
TPC-H: Total hot run time: 28667 ms |
TPC-DS: Total hot run time: 183456 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
In a rare restart window, BE can rebuild file-cache metadata in memory while
the corresponding cache files are not yet durable on disk. If that metadata is
also restored via LRU dump/load, blocks may appear as DOWNLOADED even though
the local files are missing. Subsequent reads then produce false-positive cache
hits, fail on local read, and repeatedly fall back to S3. This preserves
correctness but causes avoidable cache thrashing and latency jitter.
Root cause:
The read path treated DOWNLOADED as a valid local hit source and fell back to
remote reads on failure, but it did not actively invalidate stale metadata when
the local cache file was gone.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)