[Fix](Cloud)decouple min pipeline executor size from ConnectContext#60958
Open
CalvinKirs wants to merge 5 commits intoapache:masterfrom
Open
[Fix](Cloud)decouple min pipeline executor size from ConnectContext#60958CalvinKirs wants to merge 5 commits intoapache:masterfrom
CalvinKirs wants to merge 5 commits intoapache:masterfrom
Conversation
apache#60648 getMinPipelineExecutorSize in cloud paths implicitly depended on ConnectContext, which caused two issues: Unstable behavior when no thread-local context is available (e.g. internal/async paths). Unclear API semantics since callers could not explicitly specify the target cluster. This PR makes the API explicit by requiring clusterName. What Changed Removed the no-arg getMinPipelineExecutorSize() API and kept only: getMinPipelineExecutorSize(String clusterName). Unified SystemInfoService and CloudSystemInfoService implementations to the string-arg API. Updated SessionVariable#getParallelExecInstanceNum() to call the string-arg API, with cluster resolved from session/auth information (instead of directly depending on ConnectContext). Added synchronization in ConnectContext:
CalvinKirs
requested review from
dataroaring,
gavinchou and
w41ter
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
morningman
reviewed
Mar 2, 2026
| @@ -4176,6 +4180,10 @@ public void setDebugSkipFoldConstant(boolean debugSkipFoldConstant) { | |||
| } | |||
|
|
|||
| public int getParallelExecInstanceNum() { | |||
Contributor
There was a problem hiding this comment.
Remove this unused method
| return clusterName; | ||
| } | ||
|
|
||
| private static String resolveCloudClusterName(ConnectContext connectContext) { |
Contributor
There was a problem hiding this comment.
This method is same as in SessionVariables.java?
Contributor
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
Member
Author
|
run buildall |
CalvinKirs
added a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Mar 3, 2026
CalvinKirs
added a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Mar 3, 2026
…instance calculation" This reverts commit fc550be.
TPC-H: Total hot run time: 29137 ms |
TPC-DS: Total hot run time: 184054 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#60648
getMinPipelineExecutorSize in cloud paths implicitly depended on ConnectContext, which caused two issues:
Unstable behavior when no thread-local context is available (e.g. internal/async paths). Unclear API semantics since callers could not explicitly specify the target cluster. This PR makes the API explicit by requiring clusterName.
What Changed
Removed the no-arg getMinPipelineExecutorSize() API and kept only: getMinPipelineExecutorSize(String clusterName). Unified SystemInfoService and CloudSystemInfoService implementations to the string-arg API. Updated SessionVariable#getParallelExecInstanceNum() to call the string-arg API, with cluster resolved from session/auth information (instead of directly depending on ConnectContext). Added synchronization in ConnectContext:
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)