[enhance](load) exclude version-gap replicas from success counting in quorum success#60953
Open
sollhui wants to merge 1 commit intoapache:masterfrom
Open
[enhance](load) exclude version-gap replicas from success counting in quorum success#60953sollhui wants to merge 1 commit intoapache:masterfrom
sollhui wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage |
sollhui
force-pushed
the
opt_quorum_success
branch
from
89f57c7 to
481f7e6
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 28849 ms |
TPC-DS: Total hot run time: 184100 ms |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 29183 ms |
TPC-DS: Total hot run time: 183500 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using majority write (quorum success), BE does not distinguish between replicas
with continuous versions and replicas with version gaps (
lastFailedVersion >= 0).This causes inconsistency with FE's commit check, which correctly excludes
version-gap replicas from success counting.
Bad Case
Consider 3 replicas on nodes 1, 2, 3 with
load_required_replica_num = 2:Node 3 now has a version gap (
lastFailedVersion >= 0).so
successReplicaNum = 1 < 2, commit fails.but FE rejects the transaction.
The correct behavior for the second write:
Solution
Pass per-tablet version-gap backend information from FE to BE via a new thrift field
map<tablet_id, list<backend_id>> tablet_version_gap_backendsinTOlapTablePartition.On the BE side, when counting successful replicas for majority write in both
VTabletWriter(V1) andVTabletWriterV2, exclude version-gap backends fromthe
finished_tablets_replicacounter. This makes BE's quorum check consistentwith FE's commit check.
Changes
tablet_version_gap_backendsfield toTOlapTablePartitiongetPartitionVersionGapBackends()to compute gap backends per tablet_quorum_success_quorum_successand_create_commit_info