-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: add DROP pipe operator support #20864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jayendra13
wants to merge
5
commits into
apache:main
Choose a base branch
from
jayendra13:pipe-drop-operator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−4
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4b4ffd3
feat: add DROP pipe operator support
jayendra13 5a8289a
Merge branch 'main' into pipe-drop-operator
jayendra13 26735bb
Merge branch 'main' into pipe-drop-operator
jayendra13 3aef4b0
Merge branch 'main' into pipe-drop-operator
jayendra13 018e156
Merge branch 'main' into pipe-drop-operator
jayendra13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -196,6 +196,32 @@ query TII | |
| apples 2 123 | ||
| bananas 5 NULL | ||
|
|
||
| # DROP pipe - drop two columns | ||
| query RT | ||
| SELECT * FROM test |> DROP a, n | ||
| ---- | ||
| 1.1 a | ||
| 2.2 b | ||
| 3.3 c | ||
|
|
||
| # DROP pipe - drop single column | ||
| query IRT | ||
| SELECT * FROM test |> DROP n | ||
| ---- | ||
| 1 1.1 a | ||
| 2 2.2 b | ||
| 3 3.3 c | ||
|
|
||
| # DROP pipe - chained with other operators | ||
| query R | ||
| SELECT * FROM test |> WHERE a > 1 |> DROP a, c, n | ||
| ---- | ||
| 2.2 | ||
| 3.3 | ||
|
|
||
| # Error: DROP non-existent column | ||
| statement error | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we validate the specific error that comes here too? |
||
| SELECT * FROM test |> DROP nonexistent | ||
| # Config reset | ||
| statement ok | ||
| RESET datafusion.sql_parser.dialect; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to have a test case covering this
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the https://github.com/google/googlesql/blob/master/docs/pipe-syntax.md#drop-pipe-operator makes
column_namerequired (|> DROP column_name [, ...]), which would make this a parse error rather than a planner error, and it feels like it belongs in sqlparser instead. Could you confirm I'm reading the spec right? If so, I'll need to fix it in the upstream crate first.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the spec, just basing it off the code I see here (if we need to ensure columns aren't empty here then it means its possible to be empty? Or its just safety?)