Create workspace with core and util crates#1414
Create workspace with core and util crates#1414timsaucer wants to merge 13 commits intoapache:mainfrom
Conversation
e2a4ec6 to
bdf3402
Compare
|
FYI @kevinjqliu |
…e do not need this test
976ae54 to
0be1501
Compare
davisp
left a comment
There was a problem hiding this comment.
+1
Everything looks straightforward to me. I only had the one minor question on the removed cargo config.
| @@ -1,5 +0,0 @@ | |||
| [target.x86_64-apple-darwin] | |||
| rustflags = ["-C", "link-arg=-undefined", "-C", "link-arg=dynamic_lookup"] | |||
There was a problem hiding this comment.
Am I missing where these got moved to, or do we just not need them any more?
There was a problem hiding this comment.
Removed because these were serving the same functionality as the pyo3_build_config::add_extension_module_link_args() in build.rs
There was a problem hiding this comment.
speaking of build.rs, i was testing out this integration in iceberg-rust and claude mentioned that i need to create my own build.rs file for compatibility
is this expected?
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM, i built iceberg-rust using this branch (https://github.com/kevinjqliu/iceberg-rust/pull/8/files#diff-1a7b28a196f60421838fd52ca356647a835081dc3095f1b55d526c27580cb677R23)
one nit: do you prefer the crate to be named -util or -utils?
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Which issue does this PR close?
Closes #1395.
Rationale for this change
For our downstream users who are implementing FFI based extensions, there are a handful of useful utility functions
that we are currently requiring them to copy. This is a poor way to keep code up to date. This PR creates a utility crate that our downstream users can utilize. This also helps to ensure that as our interfaces get updated that those changes propagate properly to our downstream users.
Also this change ensures our example is on the same code version as the main repository.
What changes are included in this PR?
core,utiland the FFI example.Are there any user-facing changes?
Yes, there is a slight change in that the
utilsmodule ofdatafusion-pythonhas been removed. Instead users can now change their dependency to the newdatafusion-python-utilcrate.