GH-552: [Vector] Add absent methods to the UnionFixedSizeListWriter#1052
Conversation
This comment has been minimized.
This comment has been minimized.
|
Please add the |
jbonofre
left a comment
There was a problem hiding this comment.
LGTM, thanks !
I have just a couple of minor comments.
| @@ -123,8 +123,6 @@ public void setPosition(int index) { | |||
| <#assign lowerName = minor.class?uncap_first /> | |||
| <#if lowerName == "int" ><#assign lowerName = "integer" /></#if> | |||
| <#assign upperName = minor.class?upper_case /> | |||
There was a problem hiding this comment.
To be consistent with UnionFixedSizeListWrite, maybe we should add @Override on writes...(long start, ArrowBuf buffer, ArrowType arrowType) methods ?
There was a problem hiding this comment.
Yes, let me add it.
There was a problem hiding this comment.
Added missing override annotations to the UnionListWriter
| assertEquals(expectedField, writer.getField()); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we need a test around write(TimeStampNanoTZHolder) ?
There was a problem hiding this comment.
Yes, let me add it as well.
There was a problem hiding this comment.
Add the testWriterUsingHolderTimeStampNanoTZField test.
|
@axreldable do you mind to do the two minor changes I proposed ? I would like to merge this one for Arrow Java 19.0.0 release. Thanks ! |
@jbonofre , sure, added. Could you please kick off the build? |
|
@axreldable here we go 😄 Thanks ! I will merge as soon as CI is happy 😄 |
What's Changed
Add absent methods to the
UnionFixedSizeListWriter.UnionFixedSizeListWritertemplate with theUnionListWritertemplate, which added the following previously absent methods to the generatedUnionFixedSizeListWriterclass:structName = name;for 2 existing methods (align them with other similar methods):UnionListWritertemplate + add missing overrides.This fix adds override annotations to the
UnionListWritergenerated class and extend/fix the code of theUnionFixedSizeListWritergenerated class. So, the change is backward compatible.See the gists for the generated writer classes:
Inspired by this PR.
Closes #552 .