Conversation
euclio
force-pushed
the
workspace
branch
2 times, most recently
from
a58659b to
b95a179
Compare
| - name: "relm: build async example" | ||
| run: cargo build --manifest-path relm-examples/examples/async/Cargo.toml | ||
|
|
||
| - name: "relm: build webkit-test example" |
There was a problem hiding this comment.
The webkit example was kept separate so that if it fails because the crate is outdated or something, it's easy to see.
There was a problem hiding this comment.
Got it, I can move it back to its own crate. Would you like me to keep the other examples separate as well? The buttons-attribute test appeared to be duplicated.
euclio
force-pushed
the
workspace
branch
3 times, most recently
from
fc2fe9b to
5885ba7
Compare
|
This is ready for another review. I pulled the webkit example back into its own crate. Also, I noticed the main crate's tests weren't passing so I fixed them and added them to CI. |
euclio
force-pushed
the
workspace
branch
2 times, most recently
from
730d80b to
15f712c
Compare
|
@antoyo Rebased. I decided to leave the examples as-is in their own crates. CI doesn't test them, just builds them. I think the main useful change here is that the main relm crate gets tested in CI now. |
|
We could also modify CI to just test and build everything in one go using the |
2 participants
This enables running commands across all the crates at once, as well as making the crates share a Cargo.lock and an output directory.