Skip to content

Remove PR issue reference requirement from AI system prompt#48

Merged
slavingia merged 2 commits intomainfrom
devin/1755017190-remove-pr-issue-reference-requirement
Aug 12, 2025
Merged

Remove PR issue reference requirement from AI system prompt#48
slavingia merged 2 commits intomainfrom
devin/1755017190-remove-pr-issue-reference-requirement

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Remove PR issue reference requirement from AI system prompt

Summary

Removes the requirement for pull requests to reference issues using "Closes #123" or "Fixes #456" format from both the AI system prompt and contributing guidelines. This change prevents the Jacquez GitHub bot from posting unwanted comments about PR issue linking format.

Key changes:

  • Removed PR issue reference rule from AI system prompt in app/api/webhook/route.ts (line 179)
  • Removed corresponding requirement from CONTRIBUTING.md (line 25) and renumbered remaining requirements
  • No logic changes to webhook processing or AI response parsing

Review & Testing Checklist for Human

  • Verify requirement removal intent: Confirm that removing the PR issue reference requirement from both the AI prompt AND the contributing guidelines aligns with your actual contributing standards
  • Test AI bot behavior: Create a test PR without "Closes #123" format in a repo with Jacquez installed to verify the bot no longer comments about missing issue references
  • Verify CONTRIBUTING.md formatting: Check that the renumbered requirements in CONTRIBUTING.md are properly formatted and make sense in sequence

Recommended test plan: Create a test PR in a repository where Jacquez is installed, ensure the PR description doesn't include "Closes #123" format, and verify the bot doesn't post a comment about missing issue references.


Diagram

%%{ init : { "theme" : "default" }}%%
graph TD
    webhook["app/api/webhook/route.ts<br/>generateFriendlyResponse()"]:::major-edit
    contributing["CONTRIBUTING.md<br/>PR Requirements"]:::major-edit
    systemPrompt["AI System Prompt<br/>Violation Rules"]:::major-edit
    tests["tests/webhook.test.ts<br/>JSON Parsing Tests"]:::context
    
    webhook --> systemPrompt
    contributing --> systemPrompt
    systemPrompt --> aiComment["AI Comment Decision"]
    tests --> webhook
    
    webhook -.->|"Removed: PR issue reference rule"| systemPrompt
    contributing -.->|"Removed: Closes #123 requirement"| systemPrompt
    
    subgraph Legend
        L1[Major Edit]:::major-edit
        L2[Minor Edit]:::minor-edit  
        L3[Context/No Edit]:::context
    end

classDef major-edit fill:#90EE90
classDef minor-edit fill:#ADD8E6
classDef context fill:#FFFFFF
Loading

Notes

  • Session details: Link to Devin run: https://app.devin.ai/sessions/4b4a5be9ba8b4f51bdc8b45088604ee2, requested by @slavingia
  • Testing limitation: Could not test end-to-end webhook functionality locally as it requires live GitHub webhook events
  • Lint and unit tests: All existing tests pass, confirming no regressions in JSON parsing logic
  • AI behavior impact: This change directly affects the Jacquez bot's commenting behavior on GitHub repositories

…ibuting guidelines

- Remove 'Closes #123' or 'Fixes #456' requirement from AI system prompt
- Remove corresponding requirement from CONTRIBUTING.md
- Renumber remaining PR requirements in contributing guidelines

This prevents the bot from generating unwanted comments about PR issue linking format that shouldn't be enforced per user feedback.

Co-Authored-By: Sahil Lavingia <sahil@gumroad.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
jacquez Ready Preview Comment Aug 12, 2025 5:07pm

@slavingia slavingia merged commit 2673754 into main Aug 12, 2025
2 of 3 checks passed
@slavingia slavingia deleted the devin/1755017190-remove-pr-issue-reference-requirement branch August 12, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant