Conversation
…ibuting guidelines - Remove 'Closes #123' or 'Fixes #456' requirement from AI system prompt - Remove corresponding requirement from CONTRIBUTING.md - Renumber remaining PR requirements in contributing guidelines This prevents the bot from generating unwanted comments about PR issue linking format that shouldn't be enforced per user feedback. Co-Authored-By: Sahil Lavingia <sahil@gumroad.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove PR issue reference requirement from AI system prompt
Summary
Removes the requirement for pull requests to reference issues using "Closes #123" or "Fixes #456" format from both the AI system prompt and contributing guidelines. This change prevents the Jacquez GitHub bot from posting unwanted comments about PR issue linking format.
Key changes:
app/api/webhook/route.ts(line 179)CONTRIBUTING.md(line 25) and renumbered remaining requirementsReview & Testing Checklist for Human
Recommended test plan: Create a test PR in a repository where Jacquez is installed, ensure the PR description doesn't include "Closes #123" format, and verify the bot doesn't post a comment about missing issue references.
Diagram
%%{ init : { "theme" : "default" }}%% graph TD webhook["app/api/webhook/route.ts<br/>generateFriendlyResponse()"]:::major-edit contributing["CONTRIBUTING.md<br/>PR Requirements"]:::major-edit systemPrompt["AI System Prompt<br/>Violation Rules"]:::major-edit tests["tests/webhook.test.ts<br/>JSON Parsing Tests"]:::context webhook --> systemPrompt contributing --> systemPrompt systemPrompt --> aiComment["AI Comment Decision"] tests --> webhook webhook -.->|"Removed: PR issue reference rule"| systemPrompt contributing -.->|"Removed: Closes #123 requirement"| systemPrompt subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#ADD8E6 classDef context fill:#FFFFFFNotes