Allow user to specify the step interval#10
Open
thgaskell wants to merge 1 commit intoantiwork:masterfrom
thgaskell:step-interval
Open
Allow user to specify the step interval#10thgaskell wants to merge 1 commit intoantiwork:masterfrom thgaskell:step-interval
thgaskell wants to merge 1 commit intoantiwork:masterfrom
thgaskell:step-interval
Conversation
* Defaults to 1 second interval if step parameter is not provided or if invalid value * Added test cases
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it would be a nice feature to allow the user the option to specify how often the
onTickcallback function is called. Completely optional, so it shouldn't break any previous implementations.