refactor: File Session.

[prmukherj]

Context

The 'get_field_data' method of File Session is updated to be consistent with solver field data and use generic methods already available in the interface instead of new (duplicate) methods. These delicacies were the primary reason for error as reported in #5036. Moreover the method to get surface data was swallowing a data internally in such cases and returning wrong data.

Change Summary

Used common methods already available in field_data_interfaces.py to avoid any of the above issues.

Impact

The user will get expected output from "file_session.fields.field_data.get_field_data" now and also the output type will be consistent with "solver.fields.field_data.get_field_data".

A test has been added to check the return type.

[prmukherj]

The PR: #5037 will be superseded by this PR.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}

[Copilot]

Pull request overview

Refactors offline FileSession field-data retrieval to align return types/behavior with solver field data, addressing issue #5036 where SurfaceFieldDataRequest.data_types order could affect output shape/type.

Changes:

• Reworked FileFieldData surface/scalar/vector fetch paths to build a common intermediate structure and delegate formatting to _ReturnFieldData.
• Updated file-session tests to use the new SurfaceData object-style access (.vertices, .connectivity) and added a regression test for string data_types ordering.
• Updated offline File Session user-guide examples to reflect the new access pattern.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
src/ansys/fluent/core/file_session.py	Refactors surface/scalar/vector field-data retrieval to use _ReturnFieldData and provide consistent return types.
tests/test_file_session.py	Updates assertions for new SurfaceData return type and adds regression coverage for string data_types order.
doc/source/user_guide/offline/file_session.rst	Updates examples to use .vertices access (and combined surface request example).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mkundu1]

Please consider adding the following flake8 check to catch similar issues in future during pre-commit.

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index b90b87c7f8a..dd9c0e1accc 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -33,6 +33,7 @@ repos:
       --max-complexity, "10",
       --max-line-length, "88",
       --extend-ignore, E203 E501 C901 B007 B009 B010 B011 B028,
+      --extend-select, B909,
       src, doc, examples, tests
     ]

[prmukherj]

Please consider adding the following flake8 check to catch similar issues in future during pre-commit.

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index b90b87c7f8a..dd9c0e1accc 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -33,6 +33,7 @@ repos:
       --max-complexity, "10",
       --max-line-length, "88",
       --extend-ignore, E203 E501 C901 B007 B009 B010 B011 B028,
+      --extend-select, B909,
       src, doc, examples, tests
     ]

Done, Thank you.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.